Skip to content

Commit a680903

Browse files
RachelElysiaJacob Shandling
andauthored
FE: Fix flaky host summary tooltip test (#24029)
Let's see if this is any better - [x] Added/updated tests - [x] Manual QA for all new/changed functionality `test-js (ubuntu-latest)` SuccessCount / RunCount: 5/5 🎉 ___ after merging `main`: `test-js (ubuntu-latest)` SuccessCount / RunCount: 5/5 __ 10/10 total 🎉🎉 --------- Co-authored-by: Jacob Shandling <[email protected]>
1 parent 3b64f10 commit a680903

File tree

1 file changed

+45
-43
lines changed

1 file changed

+45
-43
lines changed

frontend/pages/hosts/details/cards/HostSummary/HostSummary.tests.tsx

Lines changed: 45 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from "react";
22
import { noop } from "lodash";
3-
import { screen, waitFor } from "@testing-library/react";
3+
import { screen, fireEvent } from "@testing-library/react";
44
import { createCustomRenderer } from "test/test-utils";
55

66
import createMockUser from "__mocks__/userMock";
@@ -50,7 +50,7 @@ describe("Host Summary section", () => {
5050
const osqueryVersion = summaryData.osquery_version as string;
5151
const fleetdVersion = summaryData.fleet_desktop_version as string;
5252

53-
const { user } = render(
53+
render(
5454
<HostSummary
5555
summaryData={summaryData}
5656
showRefetchSpinner={false}
@@ -60,53 +60,55 @@ describe("Host Summary section", () => {
6060
);
6161

6262
expect(screen.getByText("Agent")).toBeInTheDocument();
63-
await waitFor(() => {
64-
waitFor(() => {
65-
user.hover(screen.getByText(new RegExp(orbitVersion, "i")));
66-
});
6763

68-
expect(
69-
screen.getByText(new RegExp(osqueryVersion, "i"))
70-
).toBeInTheDocument();
71-
expect(
72-
screen.getByText(new RegExp(fleetdVersion, "i"))
73-
).toBeInTheDocument();
74-
});
64+
await fireEvent.mouseEnter(
65+
screen.getByText(new RegExp(orbitVersion, "i"))
66+
);
67+
68+
expect(
69+
screen.getByText(new RegExp(osqueryVersion, "i"))
70+
).toBeInTheDocument();
71+
expect(
72+
screen.getByText(new RegExp(fleetdVersion, "i"))
73+
).toBeInTheDocument();
7574
});
7675

77-
// it("omit fleet desktop from tooltip if no fleet desktop version", async () => {
78-
// const render = createCustomRenderer({
79-
// context: {
80-
// app: {
81-
// isPremiumTier: true,
82-
// isGlobalAdmin: true,
83-
// currentUser: createMockUser(),
84-
// },
85-
// },
86-
// });
87-
// const summaryData = createMockHostSummary({
88-
// fleet_desktop_version: null,
89-
// });
90-
// const orbitVersion = summaryData.orbit_version as string;
91-
// const osqueryVersion = summaryData.osquery_version as string;
76+
it("omit fleet desktop from tooltip if no fleet desktop version", async () => {
77+
const render = createCustomRenderer({
78+
context: {
79+
app: {
80+
isPremiumTier: true,
81+
isGlobalAdmin: true,
82+
currentUser: createMockUser(),
83+
},
84+
},
85+
});
86+
const summaryData = createMockHostSummary({
87+
fleet_desktop_version: null,
88+
});
89+
const orbitVersion = summaryData.orbit_version as string;
90+
const osqueryVersion = summaryData.osquery_version as string;
91+
92+
render(
93+
<HostSummary
94+
summaryData={summaryData}
95+
showRefetchSpinner={false}
96+
onRefetchHost={noop}
97+
renderActionDropdown={() => null}
98+
/>
99+
);
92100

93-
// const { user } = render(
94-
// <HostSummary
95-
// summaryData={summaryData}
96-
// showRefetchSpinner={false}
97-
// onRefetchHost={noop}
98-
// renderActionDropdown={() => null}
99-
// />
100-
// );
101+
expect(screen.getByText("Agent")).toBeInTheDocument();
101102

102-
// expect(screen.getByText("Agent")).toBeInTheDocument();
103-
// await user.hover(screen.getByText(orbitVersion));
103+
await fireEvent.mouseEnter(
104+
screen.getByText(new RegExp(orbitVersion, "i"))
105+
);
104106

105-
// expect(
106-
// screen.getByText(new RegExp(osqueryVersion, "i"))
107-
// ).toBeInTheDocument();
108-
// expect(screen.queryByText(/Fleet desktop:/i)).not.toBeInTheDocument();
109-
// });
107+
expect(
108+
screen.getByText(new RegExp(osqueryVersion, "i"))
109+
).toBeInTheDocument();
110+
expect(screen.queryByText(/Fleet desktop:/i)).not.toBeInTheDocument();
111+
});
110112

111113
it("for Chromebooks, render Agent header with osquery_version that is the fleetd chrome version and no tooltip", async () => {
112114
const render = createCustomRenderer({

0 commit comments

Comments
 (0)