feat(genkit-tools): support trace uploads via tools router #3735
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbushi
reviewed
Oct 22, 2025
|
|
||
| /** Adds a trace to the trace store */ | ||
| addTrace: loggedProcedure | ||
| .input(TraceDataSchema) |
There was a problem hiding this comment.
Looks like this is specific for Genkit traces? The schema does not say anything Genkit specific but recent conversations with Pavel has led me to believe that there is no universal format here....
This is fine, wondering if we should surface this requirement to the user somewhere.
There was a problem hiding this comment.
@ssbushi yes that's right. these are genkit traces. Are you thinking just a comment for now? Or something more (like a specific TS type)?
ssbushi
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used by Dev UI (and other? tools) for team collaboration and for customer/community support.
Checklist (if applicable):