Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process the HTML body of a message #308

Closed
wants to merge 1 commit into from

Conversation

smith981
Copy link

@smith981 smith981 commented Jun 5, 2023

I went ahead and rebased #305 onto master. Hopefully this works, if not I'll do my best.

For Postmark mailer support
@DannyvdSluijs
Copy link
Collaborator

DannyvdSluijs commented Jun 13, 2023

@smith981 thanks for opening a pull request.

I still have some concerns about the points I mentioned in #305, could you take a look and see if there is anything possible or if you see things differently?

Also with regards to the fix you're proposing could you add a test case to validate the functionality and make sure it will keep working in the future? And while I was checking the code it seemed to me we now apply the same conversion twice which comes with time and I/O penalty I would assume. Any inputs on that point maybe?

@DannyvdSluijs
Copy link
Collaborator

Closing due to lack of response by PR author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants