Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #320

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^10.5. If you would like to also upgrade your tests, you may run the PHPUnit 10 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-mail-css-inliner.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "fedeisas/laravel-mail-css-inliner": "dev-l11-compatibility",
    }
}

Finally, run: composer update

@rolfdenhartog rolfdenhartog mentioned this pull request Mar 12, 2024
@DannyvdSluijs
Copy link
Collaborator

@laravel-shift the PR for some reason doesn’t trigger the pipeline. Can you take a look?

@TSchuermans
Copy link

@DannyvdSluijs I might be wrong, but it seems that the CI is only triggered on the master branch.
Seeing as the branch is called l11-compatibility might explain this.

@DannyvdSluijs
Copy link
Collaborator

DannyvdSluijs commented Apr 11, 2024

@TSchuermans I've taken a look and the same issue also applies to #316. But then #308 shows it has worked before.

I've created and merged #323 in order to bring the workflow to a updated state.

Now linting shows no errors anymore

I'm rebasing now and the checks are running.

@DannyvdSluijs DannyvdSluijs merged commit c6916c3 into fedeisas:master Apr 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants