Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tables for support github teams #311

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

jaorr95
Copy link
Contributor

@jaorr95 jaorr95 commented Aug 15, 2023

Description

Add schema to support to teams and teams_memberships stream.

Related PR: faros-ai/airbyte-connectors#1112

Type of change

(Delete what does not apply)

  • New feature (non-breaking change which adds functionality)

Checklist

(Delete what does not apply)

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@thomas-gerber
Copy link
Contributor

thomas-gerber commented Aug 15, 2023

Thank you for your contribution @jaorr95 ;
@ted-faros I am thinking of recommending changes to keep the CE models a subset of our paid product, so that we can easily automate schema upgrades in the future.
i.e.

  • vcs_Team:
    • remove slug, privacy, url
    • base id on source, uid
  • vcs_TeamMember:
    • rename to vcs_TeamMembership
    • remove state, role, source

@ted-faros what do you think?
@jaorr95 would that be acceptable?

@ted-faros
Copy link
Contributor

@thomas-gerber I agree.

@jaorr95
Copy link
Contributor Author

jaorr95 commented Aug 21, 2023

@thomas-gerber i made the changes that you suggested

@ellipsis-dev
Copy link

ellipsis-dev bot commented Aug 21, 2023

We've released some new upgrades! Please create an account at https://bitbuilder.ai/home to continue using BitBuilder.

@thomas-gerber
Copy link
Contributor

Confirmed that it upgrades properly.

Copy link
Contributor

@thomas-gerber thomas-gerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the compatibility with our data models
Verified it upgrades properly

@thomas-gerber thomas-gerber merged commit a467dc0 into faros-ai:main Aug 22, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants