Feat/add stream teams GitHub #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaorr95
requested review from
cjwooo,
tovbinm,
ypc-faros and
willmarks
as code owners
tovbinm
reviewed
Aug 15, 2023
destinations/airbyte-faros-destination/src/converters/github/team_memberships.ts
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Aug 15, 2023
destinations/airbyte-faros-destination/src/converters/github/team_memberships.ts
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Aug 15, 2023
destinations/airbyte-faros-destination/src/converters/github/team_memberships.ts
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Aug 15, 2023
destinations/airbyte-faros-destination/src/converters/github/team_memberships.ts
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Aug 15, 2023
4 tasks
tovbinm
reviewed
Aug 21, 2023
| source, | ||
| }; | ||
|
|
||
| res.push({ |
There was a problem hiding this comment.
In order to avoid writing the same entries, you can also a check similar to:
(same for all entries you write)
tovbinm
approved these changes
Aug 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to
teamsandtems_membershipsstreamsRelated PR: faros-ai/faros-community-edition#311
Type of change
Related issues
Migration notes
Extra info