Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favorited only filter #5

Closed
wants to merge 15 commits into from
Closed

Add favorited only filter #5

wants to merge 15 commits into from

Commits on Mar 18, 2024

  1. add favorited only filter item on topBarLeading and toggle state when… 

    … tapped
    @ewa1989
    ewa1989 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    9056130 View commit details
    Browse the repository at this point in the history

  2. use favoritedOnlyFilterEnabled just to show all items or nothing

    @ewa1989
    ewa1989 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ac8c2bd View commit details
    Browse the repository at this point in the history

  3. filter sessions according to favorited only filter

    @ewa1989
    ewa1989 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    993463f View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. change favorited only filter style to show pulldown picker

    @ewa1989
    ewa1989 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7c363b8 View commit details
    Browse the repository at this point in the history

  2. swap filter item position with map item for putting filter item next … 

    …to search bar on iPad
    @ewa1989
    ewa1989 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    9d12f98 View commit details
    Browse the repository at this point in the history

  3. remove unused property

    @ewa1989
    ewa1989 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    24ad60b View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Merge branch 'add-check-favorite-session-feature' into add-favorited-… 

    …only-filter

# Conflicts:
#	MyLibrary/Sources/ScheduleFeature/Schedule.swift
    @ewa1989
    ewa1989 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8888212 View commit details
    Browse the repository at this point in the history

  2. move [Schedule].filtered to SharedModels and add a test

    @ewa1989
    ewa1989 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4d2590a View commit details
    Browse the repository at this point in the history

  3. separate FilterItem from Action since selectedFilter is binded with P… 

    …icker and FilterItem doesn't need to be Action
    @ewa1989
    ewa1989 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1772e94 View commit details
    Browse the repository at this point in the history

  4. change FilterItem to inherit LocalizedStringKey for more localization… 

    … safety
    @ewa1989
    ewa1989 committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4fe7be7 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Merge branch 'add-check-favorite-session-feature' into add-favorited-… 

    …only-filter

# Conflicts:
#	MyLibrary/Sources/ScheduleFeature/Schedule.swift
    @ewa1989
    ewa1989 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    09189eb View commit details
    Browse the repository at this point in the history

  2. change variable name of Conference, day to conference, as other place… 

    … does
    @ewa1989
    ewa1989 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    4c6adeb View commit details
    Browse the repository at this point in the history

  3. because deleted Conference+Extension, move testSchedulesFiltered to S… 

    …cheduleTests
    @ewa1989
    ewa1989 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    6c7a050 View commit details
    Browse the repository at this point in the history

  4. change variable names of Conference, day to conference, as other plac… 

    …e does
    @ewa1989
    ewa1989 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    3d47811 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. fix to enable to test favorite filter via Reducer.

    @ewa1989
    ewa1989 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    e1769aa View commit details
    Browse the repository at this point in the history