Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add favorited only filter #5

Closed
wants to merge 15 commits into from
Closed

Add favorited only filter #5

wants to merge 15 commits into from

Conversation

ewa1989
Copy link
Owner

@ewa1989 ewa1989 commented Mar 18, 2024 •
edited
Loading

Add check favorite session feature as below.

In ScheduleView, add a filter to show only favorited sessions.

Ref: tryswift#40

Note

  • add filter icon ("line.horizontal.3.decrease") on trailing of toolbar and show pulldown filter items ("All" or "Favorites") when tapped
  • show message that there's no items to show according to filter condition
  • since filter item selecting condition binds with Picker in SwiftUI, add test only for code of filtering favorite sessions

@ewa1989
add favorited only filter item on topBarLeading and toggle state when…
9056130 
… tapped
@ewa1989
use favoritedOnlyFilterEnabled just to show all items or nothing
ac8c2bd
@ewa1989
filter sessions according to favorited only filter
993463f
@ewa1989
change favorited only filter style to show pulldown picker
7c363b8
@ewa1989
swap filter item position with map item for putting filter item next …
9d12f98 
…to search bar on iPad
@ewa1989
remove unused property
24ad60b
@ewa1989
Merge branch 'add-check-favorite-session-feature' into add-favorited-…
8888212 
…only-filter

# Conflicts:
#	MyLibrary/Sources/ScheduleFeature/Schedule.swift
@ewa1989
move [Schedule].filtered to SharedModels and add a test
4d2590a
@ewa1989
separate FilterItem from Action since selectedFilter is binded with P…
1772e94 
…icker and FilterItem doesn't need to be Action
@ewa1989
change FilterItem to inherit LocalizedStringKey for more localization…
4fe7be7 
… safety
@ewa1989 ewa1989 mentioned this pull request Mar 20, 2024
Open
@ewa1989 ewa1989 closed this Apr 1, 2024
@ewa1989 ewa1989 deleted the add-favorited-only-filter branch April 1, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ewa1989