-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ROS1 Noetic #370
Comments
@FullMetalNicky please make a PR :) |
The following branch contains the minimal fix to compile Some thoughts: |
@tkazik I can confirm that this fixes things on 20.04. We should absolutely merge this to master, however, it would be best not to break 18.04.... Can you get one of your antiquated officemates @clanegge or @michaelpantic to try to build this branch? Otherwise I'lll set up a dockerfile... |
@alexmillane Just tried it out on my machine running good, old & reliable 18.04. The branch |
Cheers bro. Thanks for testing that :). I'll make a PR from Tim's branch and merge it, as well as ethz-asl/cblox#43 and ethz-asl/voxgraph#57 |
As many EU-funded projects now target Ubuntu 20.04, it would be nice if you added support for ROS1 Noetic.
I tried building the project according to the instructions here with ROS Noetic. I got an endless list of compilation errors related to PCL in the voxblox_ros package.
ROS Noetic uses PCL 1.10 which requires C++14 to compile, so I changed the CMakeLists.txt in voxblox/voxblox_ros:
#add_definitions(-std=c++11 -Wall -Wextra)
set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
Now the package was built with a warning "Policy CMP0048 is not set: project() command manages VERSION variables.". I have no idea what that means :) I just ran your cow demo and it seems to run correctly.
Should I make a PR? I didn't not thoroughly test the solution....
The text was updated successfully, but these errors were encountered: