Support newer GCC versions and minor cleanup #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmillane
approved these changes
Apr 14, 2021
| @@ -1,7 +1,7 @@ | |||
| cmake_minimum_required(VERSION 2.8.3) | |||
| project(voxgraph) | |||
|
|
|||
| add_definitions(-std=c++11 -Werror) | |||
| add_definitions(-std=c++14 -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-deprecated-copy -fPIC -DEIGEN_INITIALIZE_MATRICES_BY_NAN -fdiagnostics-color=auto) | |||
There was a problem hiding this comment.
Out of interest what's the motivation for DEIGEN_INITIALIZE_MATRICES_BY_NAN? Is it catch uninitialized matrix access?
| submap_creation_interval_(20), | ||
| verbose_(verbose) {} | ||
| verbose_(verbose), | ||
| submap_creation_interval_(20) {} |
There was a problem hiding this comment.
I would usually make the default a constexpr somewhere.
| @@ -3,6 +3,7 @@ | |||
| #include <string> | |||
| #include <vector> | |||
|
|
|||
| #include <boost/filesystem.hpp> | |||
There was a problem hiding this comment.
One day we will get stl filesystem. sigh
| const FrameId getReferenceFrameId() const { | ||
| return config_.reference_frame_id; | ||
| } | ||
| FrameId getReferenceFrameId() const { return config_.reference_frame_id; } |
There was a problem hiding this comment.
Hmm I see the recommendation on returning const copies has changed to "don't do it"
Thanks for fixing this.
|
@victorreijgwart Should we merge this? Currently, we're not building on 20.04, and this solves matters :) See: ethz-asl/voxblox#370 and ethz-asl/cblox#43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes to make sure voxgraph compiles cleanly with newer GCC versions, such as on Ubuntu 20.04.
Compiled and tested on Ubuntu 18.04 and 20.04.
Changes