kalibr_bagcreater can now handle short filenames. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 3, 2014 11:47
The installation tutorial instructs to install Eigen3. A standard Ubuntu installation has no FindEigen.cmake, but only FindEigen3.cmake. Therefore, I instructed CMake to require Eigen3 instead of Eigen.
Previously, filenames had to be at least 10 character, without filetype extension. When a filename was shorter, an empty string would be passed to int(), which results in a ValueError. With this version, when an empty string is encountered, secs is set to 0.
When the sensor_msgs/Image is converted to its numpy `ndarray` representation, it sometimes has the shape `(n, m, 1)`. This gives an error even though it is a `sensor_msgs::image_encodings::MONO8`. The underlying algorithm only supports 2D arrays, and the images were stored as 3D objects. Error: ``` TypeError: Conversion is only valid for arrays with 1 or 2 dimensions. Argument has 3 dimensions ``` Transforming the image with a reshape if and only if it has a dimension of lenght 1 solves this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, filenames had to be at least 10 character, without filetype
extension. When a filename was shorter, an empty string would be passed
to int(), which results in a ValueError. With this version, when an
empty string is encountered, secs is set to 0.