Skip to content

Update EIP-1872: grammar corrections #10530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Update EIP-1872: grammar corrections #10530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions EIPS/eip-1872.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
---

Check warning on line 1 in EIPS/eip-1872.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble is missing header(s): `description` 

warning[preamble-req]: preamble is missing header(s): `description`
--> EIPS/eip-1872.md
 |
 |
 = help: see https://ethereum.github.io/eipw/preamble-req/

Check warning on line 1 in EIPS/eip-1872.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble is missing header(s): `description` 

warning[preamble-req]: preamble is missing header(s): `description`
--> EIPS/eip-1872.md
 |
 |
 = help: see https://ethereum.github.io/eipw/preamble-req/
eip: 1872
title: Ethereum Network Upgrade Windows
author: Danno Ferrin (@shemnon)
Expand All @@ -7,8 +7,8 @@
type: Meta
created: 2018-03-25
---

Check warning on line 10 in EIPS/eip-1872.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

body is missing section(s): `Security Considerations` 

warning[markdown-req-section]: body is missing section(s): `Security Considerations`
--> EIPS/eip-1872.md
 |
 |
 = help: must be at the second level (`## Heading`)
 = help: see https://ethereum.github.io/eipw/markdown-req-section/

Check warning on line 10 in EIPS/eip-1872.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

body is missing section(s): `Security Considerations` 

warning[markdown-req-section]: body is missing section(s): `Security Considerations`
--> EIPS/eip-1872.md
 |
 |
 = help: must be at the second level (`## Heading`)
 = help: see https://ethereum.github.io/eipw/markdown-req-section/
## Simple Summary

Check warning on line 11 in EIPS/eip-1872.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

body has extra section(s) 

warning[markdown-order-section]: body has extra section(s)
   --> EIPS/eip-1872.md
    |
 11 | ## Simple Summary
    |
   ::: EIPS/eip-1872.md
    |
173 | ## Implementation
    |
    = help: see https://ethereum.github.io/eipw/markdown-order-section/

Check warning on line 11 in EIPS/eip-1872.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

body has extra section(s) 

warning[markdown-order-section]: body has extra section(s)
   --> EIPS/eip-1872.md
    |
 11 | ## Simple Summary
    |
   ::: EIPS/eip-1872.md
    |
173 | ## Implementation
    |
    = help: see https://ethereum.github.io/eipw/markdown-order-section/

A proposal to define a limited number of annual time windows in which network
upgrades (aka hard forks) should be performed within. Policies for scheduling
Expand All @@ -27,7 +27,7 @@

## Motivation

The aim of this EIP is to provide some level of regularity and predictability to
This EIP aims to provide some level of regularity and predictability to
the Ethereum network upgrade/hard fork process. This will allow service
providers such as exchanges and node operators a predictable framework to
schedule activities around. This also provides a framework to regularize the
Expand Down Expand Up @@ -146,7 +146,7 @@

The rationale for defining launch windows is to give business running Ethereum
infrastructure a predictable schedule for when upgrades may or may not occur.
Knowing when a upgrade is not going to occur gives the businesses a clear time
Knowing when an upgrade is not going to occur gives businesses a clear time
frame within which to perform internal upgrades free from external changes. It
also provides a timetable for developers and IT professionals to schedule time
off against.
Expand All @@ -167,7 +167,7 @@
testnet consensus failures. The EIP-1283 issues likely would have resulted in an
out of window upgrade because of the impact of the difficulty bomb.

<!-- ## Test Cases -->

Check warning on line 170 in EIPS/eip-1872.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

HTML comments are not allowed when `status` is `Stagnant` 

warning[markdown-html-comments]: HTML comments are not allowed when `status` is `Stagnant`
   --> EIPS/eip-1872.md
    |
170 | <!-- ## Test Cases -->
    |
   ::: EIPS/eip-1872.md
    |
171 | <!-- no test cases are relevant for this EIP -->
    |
    = help: see https://ethereum.github.io/eipw/markdown-html-comments/

Check warning on line 170 in EIPS/eip-1872.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

HTML comments are not allowed when `status` is `Stagnant` 

warning[markdown-html-comments]: HTML comments are not allowed when `status` is `Stagnant`
   --> EIPS/eip-1872.md
    |
170 | <!-- ## Test Cases -->
    |
   ::: EIPS/eip-1872.md
    |
171 | <!-- no test cases are relevant for this EIP -->
    |
    = help: see https://ethereum.github.io/eipw/markdown-html-comments/
<!-- no test cases are relevant for this EIP -->

## Implementation
Expand Down
Loading