Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update record names as reserved words/variables and new record definition syntax #64

Merged
merged 24 commits into from
Oct 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8527193
Record names as reserved_words/Variables and new record definition sy…
choptastic Oct 9, 2024
adb4ffd
Fix small typos
choptastic Oct 9, 2024
a87bc7e
Fixing more typos
choptastic Oct 9, 2024
964d971
Fix 'receive' typo
choptastic Oct 9, 2024
83ccc12
EEP-0072: Fix janky and busted phrasing
choptastic Oct 9, 2024
6d24820
eep-0072: Clarifying language and more examples
choptastic Oct 9, 2024
8e0e09c
Update eeps/eep-0072.md
choptastic Oct 9, 2024
f5d0d3f
eep-0072: phrasing
choptastic Oct 9, 2024
87a637b
EEP0072-Expand Motivations and specs for definition
choptastic Oct 9, 2024
8036769
EEP-0072: Remove excess hyphenation
choptastic Oct 9, 2024
3ddb0c6
EEP-0072: Add note about ASN1 and Corba
choptastic Oct 9, 2024
7c28c8a
EEP-0072: Attempt to fix spacing to alleviate linter errors
choptastic Oct 10, 2024
608739d
EEP-wq0072: Add a missed blank line around header
choptastic Oct 10, 2024
c838aa4
EEP-0072: Fix (hopefully) last markdown issue
choptastic Oct 12, 2024
d60191b
Update making the new define syntax more obvious
choptastic Oct 12, 2024
7cfbd6f
Apply suggestions from code review
choptastic Oct 12, 2024
467ce8a
Fix typo
choptastic Oct 13, 2024
6a9c62b
Fix some length
choptastic Oct 13, 2024
6543ec7
Add some notes about the type system
choptastic Oct 13, 2024
5250011
Update phrasing a bit
choptastic Oct 13, 2024
8ef3dca
Update eeps/eep-0072.md
choptastic Oct 18, 2024
4fc7d01
Update eeps/eep-0072.md
choptastic Oct 18, 2024
dbfb39e
Update variable name phrasing
choptastic Oct 18, 2024
3164da9
Fix some paraphraphs
choptastic Oct 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
choptastic committed Oct 13, 2024
commit 467ce8ada15a7adc6165a9000c3c9cfb713865f4
5 changes: 3 additions & 2 deletions eeps/eep-0072.md
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@ go() ->
```

While this approach is consistent with atom usage in the language, for reserved
words, this makes the record syntax *feel* inconsistent if you have a need for
words and capitalized atoms, this makes the record syntax *feel* inconsistent if you have a need for
naming a record with a reserved word (or term with a capital first letter). In
this case, it almost guarantees a user won't use a record named 'if',
'receive', 'fun', etc even though there may very well be a valid use case for
@@ -183,7 +183,7 @@ Implementation

To update the syntax for using records, we can safely augment the parser to
change its already existing record handling of `'#' atom '{' ... '}'` and `'#' atom '.' atom` into `'#' record_name '{' ... '}'` and `'#' record_name '.' atom`, and define
`record_name` to be `atom`, `var`, or `reserver_word`.
`record_name` to be `atom`, `var`, or `reserved_word`.

To update the record definition syntax, we can simply add a few new
modifications to the `attribute` Nonterminal to allow `'#' record_name` as name for the `record` attribute, instead of `atom` as for generic attributes.
@@ -222,6 +222,7 @@ should try to hide it. These are remaining concerns and inconsistencies:
feel that the symmetry between the usage and the definition would likely
become the default/preferred way, and that the original syntax remain for
backwards compatibility.
3. Another

Reference Implementation
========================