Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add episode on contact matrices #63
base: main
Are you sure you want to change the base?
add episode on contact matrices #63
Changes from 24 commits
53b99ef
3e986d1
5babcbf
464c9c7
10e3bba
872de06
575089e
fc398de
300fcac
50f1bbe
2948012
3b2580a
bc50ef5
0f8bf27
79b6c06
e4cc034
0971559
fe1c29e
46a351c
df6c1f6
6b220ff
ada119a
380dda9
9f2b819
1402f25
2592254
70a6051
bf4d6bf
3744e27
62266cb
a252d00
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split
argument incontact_matrix
which does the normalisation for you, although it's definitely also useful to show here how to do iot.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've altered the text slightly to 'represents the contacts between populations$i$ and $j$ ' so it is more generic, wording this episode has been tricky - if you have any more suggestions for clarity let me know!
I've also added a callout on using
split
, I think it is a useful addition to know the normalisation can be done within the functioncontact_data()
. Related to this, I think there could be come confusion about where normalisation takes place in different analyses e.g. in epidemics it happens within the model function call , I've added a callout box to the first tutorial on usingepidemics
to highlight that the contact matrix normalisation does not need to be done.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reading the various uses here how about speaking about contacts of group i with group j (which I though you used somewhere but now I can't find it) which to me does not imply any directionality but makes it clear that in rows we're specifically looking at group i. So perhaps adopt this one throughout?