-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial implementation: replace MultiMap in MoleculeRGroupsComposition class - Part 2, remove MultiMap completely #921
Open
loimu
wants to merge
19
commits into
master
Choose a base branch
from
feature/521_std_multimap_molecule_rgroups_composition_2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loimu
force-pushed
the
feature/521_std_multimap_molecule_rgroups_composition_2
branch
3 times, most recently
from
December 6, 2022 12:20
4a2a8ca
to
7300401
Compare
Partial implementation: replace MultiMap in MoleculeRGroupsComposition class - Part 2
Partial implementation: remove MultiMap implementation from the project completely. Fixes #521
loimu
force-pushed
the
feature/521_std_multimap_molecule_rgroups_composition_2
branch
from
December 7, 2022 06:26
7300401
to
7fc95c0
Compare
* #929: update test references * #929: fix .NET tests on Linux Co-authored-by: even1024 <[email protected]>
* refactoring cdxml loader * refactoring cdxml reaction loader * refactoring cdxml loader * cdxml styles fix * cdxml styles fix * clang fix * clang fix * clang fix * clang fix * stereo chemistry fix * clang fix * clang fix * padding fix * remove printf * remove printf * stereo fix * enum fix * display fix * removed bingo * removed bingo * removed bingo * removed bingo * removed bingo * cdx saver * cdx saver * cdx saver * cdx saver * prepare PR * prepare PR * prepare PR * prepare PR * prepare PR * prepare PR Co-authored-by: Roman Porozhnetov <[email protected]>
…938 (#939) * bingo removed * bump to 1.9.0-rc.1 * npm enable * misc fixes * misc fixes * misc changes * clang fix * cdx test fix * bump version to 1.9.0.rc.1 * clang fix * text size fix * unordered map fix Co-authored-by: Roman Porozhnetov <[email protected]>
Co-authored-by: Roman Porozhnetov <[email protected]> Co-authored-by: Roman Porozhnetov <[email protected]>
…943 (#952) * rgroups (#946) Co-authored-by: Roman Porozhnetov <[email protected]> * CDX import: Reaction arrows disappear when opening a file #943 (#948) * marvin cdx fix * clang fix Co-authored-by: Roman Porozhnetov <[email protected]> Co-authored-by: Roman Porozhnetov <[email protected]>
* rgroups (#946) Co-authored-by: Roman Porozhnetov <[email protected]> * CDX import: Reaction arrows disappear when opening a file #943 (#948) * marvin cdx fix * clang fix Co-authored-by: Roman Porozhnetov <[email protected]> * CDX import: Aromatized structures are not recognized when Pasting from Clipboard #950 (#953) * bond order fix * clang fix * test fix Co-authored-by: Roman Porozhnetov <[email protected]> Co-authored-by: Roman Porozhnetov <[email protected]>
Co-authored-by: Roman Porozhnetov <[email protected]> Co-authored-by: Roman Porozhnetov <[email protected]>
* added own-built freetype; removed cairo-wasm * returned freetype CMakeLists.txt to the original state * fixed freetype building * added sans fonts files * added rendere_font_face_manager; support of external fonts * added utf8 tests to indigo-ketcher * clang-format fix for sans fonts files * clang-format fix for font_face_manager files * fixed build for non UNIX builds * clang_format fix * fixed freetype build * selected FreeType License (FTL) as used license * selected FreeType License (FTL) as used license * moved sans fonts files; added OFL license file * fixed build and CMakeFiles
…928 (#977) * rbc & subst -2 (#969) Co-authored-by: Roman Porozhnetov <[email protected]> * SUBST -2 test * comment fixed Co-authored-by: Roman Porozhnetov <[email protected]>
@loimu could you update it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation: replace MultiMap with standard library container