Refactor molecule_json_saver into smaller translation units#3432
Open
Refactor molecule_json_saver into smaller translation units#3432
Conversation
Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Split molecule_json_saver.cpp into smaller files
Refactor molecule_json_saver into smaller translation units
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove-me-section
molecule_json_saver.cppinto targeted units and the shared float writer helper.Generic request
#1234 – issue nameFor release/xx branch
Optional
Backmerge request
Backmerge: #1234 – issue nameBump request
Bump version to ...The oversized
molecule_json_saver.cppwas split to keep responsibilities manageable while preserving behavior.Changes
molecule_json_saver_sgroups.cpp.molecule_json_saver_monomers.cpp.molecule_json_saver_text.cpp.saveNativeFloathelper moved to header for cross-TU use; includes trimmed in new files.Example
Original prompt
molecule_json_saver.cpphas 2,432 lines of code, which is greater than 2,000 authorized. Split it into smaller files #3414💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.