Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1800 only one of the R groups is saved to CDX format #1956

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

#1800 only one of the R groups is saved to CDX format #1956

wants to merge 16 commits into from

Conversation

durlabh-epam
Copy link
Collaborator

@durlabh-epam durlabh-epam commented May 20, 2024 •
edited by even1024
Loading

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@durlabh-epam durlabh-epam changed the title Changes to add altgroups on same level. #1800 only one of the R groups is saved to CDX format May 20, 2024
even1024
even1024 reviewed May 20, 2024
View reviewed changes
api/tests/integration/tests/formats/reactions/R3R4R5.ket Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file is in wrong folder

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will move it to molecules folder.

@even1024 even1024 linked an issue May 21, 2024 that may be closed by this pull request
Only one of the R groups is saved to CDX format. #1800
Open
even1024 and others added 13 commits May 22, 2024 01:09
@even1024
#1960 Fix error message in the SequenceLoader for an invalid sequence #…
2ba5462 
…1960 (#1961)
@even1024
Bump version to 1.21.0-dev.4 (#1963)
b15b3f6
@AliaksandrDziarkach
#1959 Preview: Saved in the Ketcher IDT file should be opened (#1967)
9df4586
@AliaksandrDziarkach
Bump to version 1.21.0-dev.5 (#1968)
36c1d15
@even1024
#1972 - Can't save KET with nameless superatom (#1973)
fe931b2
@even1024
Bump version to 1.21.0-dev.6 (#1975)
994bdab
@AliaksandrDziarkach
#1976 Too slow monomer library load (#1977)
910d3ca
@AliaksandrDziarkach
#1979 Preview: IDT sequence with leading or trailing spaces will not…
b45d44a 
… open. (#1980)
@durlabh-epam
Changes to add altgroups on same level.
128055e
@durlabh-epam
Moved ket file to molecule directory, added changes in the test and .…
1ecd0ad 
…py.out file.
@durlabh-epam
Added the correct cdxml file in ref folder.
15b1824
@durlabh-epam
Merge branch '1800_only_one_of_the_R_groups_is_saved_to_CDX_format' of …
e598a03 
…https://github.com/epam/Indigo into 1800_only_one_of_the_R_groups_is_saved_to_CDX_format
@durlabh-epam
Initial chages to accomodate empty altgroups.
5b033d2
@durlabh-epam durlabh-epam marked this pull request as draft June 17, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@even1024 even1024 even1024 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only one of the R groups is saved to CDX format.
3 participants
@durlabh-epam @even1024 @AliaksandrDziarkach