Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native start end view to track JS Screens #69

Merged
merged 16 commits into from
Aug 14, 2024
Merged

Conversation

TheMutsi
Copy link
Collaborator

@TheMutsi TheMutsi commented Aug 9, 2024

Goal

Use spans for iOS and logRNAction for Android (This will be changed in the future) to track JS screens in react-native-navigation and react-navigation

@TheMutsi TheMutsi requested a review from a team August 9, 2024 15:52
@TheMutsi TheMutsi changed the base branch from master to 5.0 August 9, 2024 15:52
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (5.0@38d73e8). Learn more about missing BASE report.

Files Patch % Lines
...s/react-native-navigation/src/NavigationTracker.ts 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             5.0      #69   +/-   ##
======================================
  Coverage       ?   77.95%           
======================================
  Files          ?       28           
  Lines          ?     1225           
  Branches       ?      100           
======================================
  Hits           ?      955           
  Misses         ?      270           
  Partials       ?        0           
Files Coverage Δ
packages/core/src/index.ts 91.15% <100.00%> (ø)
packages/react-navigation/src/index.ts 88.09% <100.00%> (ø)
...s/react-native-navigation/src/NavigationTracker.ts 95.65% <88.88%> (ø)

@TheMutsi TheMutsi requested a review from jpmunz August 13, 2024 13:12
packages/core/src/__tests__/embrace.test.ts Outdated Show resolved Hide resolved
packages/core/ios/RNEmbrace/EmbraceManager.swift Outdated Show resolved Hide resolved
packages/core/ios/RNEmbrace/EmbraceManager.swift Outdated Show resolved Hide resolved
packages/core/ios/RNEmbrace/EmbraceManager.swift Outdated Show resolved Hide resolved
packages/core/ios/RNEmbrace/EmbraceManager.swift Outdated Show resolved Hide resolved
@TheMutsi TheMutsi merged commit 681c792 into 5.0 Aug 14, 2024
1 check passed
@TheMutsi TheMutsi deleted the native-start-end-view branch August 14, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants