Native start end view to track JS Screens (#69)

* Start end view native * React Navigation * Changes * Android change + test * Change start span * Fix comment * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update packages/core/ios/RNEmbrace/EmbraceManager.swift Co-authored-by: Jonathan Munz <[email protected]> * Update embrace.test.ts * expect any RN version as long as its a string --------- Co-authored-by: Damian Mussi <[email protected]> Co-authored-by: Jonathan Munz <[email protected]>
embrace-io · Aug 14, 2024 · 681c792 · 681c792
1 parent 38d73e8
commit 681c792
Show file tree

Hide file tree

Showing 12 changed files with 283 additions and 231 deletions.
diff --git a/packages/core/android/src/main/java/io/embrace/embracewrapper/EmbraceManagerModule.java b/packages/core/android/src/main/java/io/embrace/embracewrapper/EmbraceManagerModule.java
@@ -194,7 +194,9 @@ public void startView(String screen, Promise promise) {
 
     @ReactMethod
     public void endView(String screen, Promise promise) {
+        promise.resolve(true)
         //This method is only for compatibility, Android does not need an end event to end the view, but iOS does
+        //TODO this should be changed to span in the future
     }
 
     @ReactMethod
@@ -256,7 +258,7 @@ public void logRNAction(String name, Double startTime, Double endTime, ReadableM
 
             final Map<String, Object> props = properties != null ? properties.toHashMap() : new HashMap<String, Object>();
             Embrace.getInstance().getReactNativeInternalInterface().logRnAction(name, st, et, props, payloadSize, output);
-            promise.resolve(true);
+            promise.resolve(name);
         }catch(Exception e){
             promise.resolve(false);
         }

diff --git a/packages/core/ios/RNEmbrace/EmbraceManager.m b/packages/core/ios/RNEmbrace/EmbraceManager.m
@@ -87,6 +87,14 @@ @interface RCT_EXTERN_MODULE(EmbraceManager, NSObject)
                   resolver:(RCTPromiseResolveBlock)resolve
                   rejecter:(RCTPromiseRejectBlock)reject)
 
+RCT_EXTERN_METHOD(startView:(NSString *)viewName
+                  resolver:(RCTPromiseResolveBlock)resolve
+                  rejecter:(RCTPromiseRejectBlock)reject)
+
+RCT_EXTERN_METHOD(endView:(NSString *)spanId
+                  resolver:(RCTPromiseResolveBlock)resolve
+                  rejecter:(RCTPromiseRejectBlock)reject)
+
 RCT_EXTERN_METHOD(startSpan:(NSString *)name
                   parentSpanId:(NSString *)parentSpanId
                   startTimeMs:(nonnull NSNumber *)startTimeMs