Make SessionApiTest not flakey #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bidetofevil and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
- Coverage 82.51% 82.49% -0.03%
==========================================
Files 477 477
Lines 10960 10960
Branches 1671 1671
==========================================
- Hits 9044 9041 -3
Misses 1192 1192
- Partials 724 727 +3 |
bidetofevil
force-pushed
the
hho/ba-cacher-tweak
branch
from
d4d806d
to
d987494
Compare
bidetofevil
force-pushed
the
hho/fix-concurrent-tests
branch
from
0f58df5
to
034f0f6
Compare
bidetofevil
force-pushed
the
hho/fix-concurrent-tests
branch
2 times, most recently
from
8cec184
to
f26a061
Compare
Merge activity
|
bidetofevil
changed the base branch from
hho/ba-cacher-tweak
to
graphite-base/1411
bidetofevil
force-pushed
the
hho/fix-concurrent-tests
branch
from
f26a061
to
43edcd6
Compare
bidetofevil
force-pushed
the
graphite-base/1411
branch
from
d987494
to
8663b60
Compare
bidetofevil
force-pushed
the
hho/fix-concurrent-tests
branch
from
43edcd6
to
7ac98e5
Compare
bidetofevil
force-pushed
the
graphite-base/1411
branch
2 times, most recently
from
993afa1
to
8367925
Compare
bidetofevil
force-pushed
the
hho/fix-concurrent-tests
branch
from
7ac98e5
to
37d4e48
Compare
bidetofevil
force-pushed
the
hho/fix-concurrent-tests
branch
from
37d4e48
to
eaca61e
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The SessionApiTest was flakey because whether the disk space attribute is written in the session is non-deterministic. So to make the payload predictable, I disabled that feature in this integration test verification, which is superfluous anyway since it working ought to be verified via unit tests anyway.