Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize background activity caching #1410

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Optimize background activity caching #1410

merged 2 commits into from
Sep 23, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Sep 20, 2024

Goal

Reduce min gap between background save to 2s

Testing

Add unit tests

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator Author

bidetofevil commented Sep 20, 2024

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.51%. Comparing base (d720e3f) to head (993afa1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
+ Coverage   82.49%   82.51%   +0.02%     
==========================================
  Files         477      477              
  Lines       10960    10960              
  Branches     1671     1671              
==========================================
+ Hits         9041     9044       +3     
+ Misses       1192     1191       -1     
+ Partials      727      725       -2     
Files with missing lines Coverage Δ
...ession/caching/PeriodicBackgroundActivityCacher.kt 88.88% <ø> (ø)

... and 2 files with indirect coverage changes

@bidetofevil bidetofevil marked this pull request as ready for review September 21, 2024 03:28
@bidetofevil bidetofevil requested a review from a team as a code owner September 21, 2024 03:28
@bidetofevil bidetofevil changed the base branch from main to hho/simplfy-session-props-tests September 22, 2024 04:29
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

bidetofevil commented Sep 23, 2024

Merge activity

  • Sep 23, 11:21 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Sep 23, 11:33 AM EDT: Graphite couldn't merge this PR because it had conflicts with the trunk branch.
  • Sep 23, 2:52 PM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.
  • Sep 23, 2:53 PM EDT: @bidetofevil merged this pull request with Graphite.

@bidetofevil bidetofevil changed the base branch from hho/simplfy-session-props-tests to graphite-base/1410 September 23, 2024 15:21
@bidetofevil bidetofevil changed the base branch from graphite-base/1410 to main September 23, 2024 15:31
@bidetofevil bidetofevil merged commit 8367925 into main Sep 23, 2024
7 checks passed
@bidetofevil bidetofevil deleted the hho/ba-cacher-tweak branch September 23, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants