Documented use of ember-cli-head in Octane #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
commented
Jun 20, 2020
| compatibility for generating head tags in server-rendered apps. | ||
| # ember-cli-head | ||
|
|
||
| This addon lets you populate `<head>` tag from your Ember code without any direct hacky DOM manipulation. It also provides [ember-cli-fastboot](https://github.com/ember-fastboot/ember-cli-fastboot) compatibility for generating head tags in server-rendered apps. |
There was a problem hiding this comment.
I updated the URL for ember-cli-fastboot.
ijlee2
commented
Jun 20, 2020
|
|
||
| ### Version | ||
|
|
||
| Take into account that version >= 0.3 of this addon require Ember 2.10+ and fastboot >=1.0.rc1. Please use 0.2.X if you don't fulfill both requirements. |
There was a problem hiding this comment.
Since the current version of ember-cli-head supports Ember 2.18+ and the current version of FastBoot is 2.x, I wondered if this subsection could be removed. Just in case, I kept the subsection.
ijlee2
commented
Jun 20, 2020
|
|
||
| If you make use of this mode the content of `<head>` will be the static FastBoot rendered content through the life of your App. |
There was a problem hiding this comment.
This paragraph used to belong to the Fastboot Only section. It got separated when the Upgrade section was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue #70.
In addition to documenting the use of
ember-cli-headin Octane apps (commit 1), I read the entire README to see how we can help the documentation be more clear and easier to understand for first-time users (commits 2-8).I may recommend reviewing commits one at a time.