-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning to readme about using model
in Octane
#70
Comments
I think we could even go a step further and not name it |
Sounds good. I can make a PR this weekend to add the warning and update the example code. I think renaming |
@ijlee2 yeah, I think no need to introduce a breaking change right now, but we do need to guard people against making this mistake. |
Ya, we can expose a new field though. So you could author |
I opened the PR at #81, just for updating the readme. I suggest that we make a new issue to address the ambiguity in |
Hello. A couple of weeks ago, my team introduced a bug when we Octanified our templates by changing all instances of
this.model
to@model
. We didn't realize until today that we should have left alonethis.model
inapp/templates/head.hbs
, sincemodel
refers to thehead-data
service.I was wondering if you could (1) add a warning to the readme file under https://github.com/ronco/ember-cli-head#service, and (2) update the example code to Octane,
so that other developers and teams may avoid our mistake when using Octane? I can also create a PR if you think making these changes would be a good idea.
The text was updated successfully, but these errors were encountered: