Welcome/depart/etc emails should be sent out based on location's timezone #587
Labels
Comments
bfirsh
added a commit
to bfirsh/modernomad
that referenced
this issue
Jul 18, 2019
This used to be indeterminite depending on what timezone you were in, because some tasks were in UTC and some were in local time. Email sending should use location timezone, but this will fix problem for now. See embassynetwork#587
bfirsh
added a commit
that referenced
this issue
Jul 20, 2019
This used to be indeterminite depending on what timezone you were in, because some tasks were in UTC and some were in local time. Email sending should use location timezone, but this will fix problem for now. See #587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
modernomad/core/tasks.py, the email sending logic is all based on UTC, which just lucks out as working because the cron job is run at 1pm UTC, which is the same day for Europe and US. This will break if we add weird timezones (hi australia).I haven't thought this out in great detail, but it should probably send out emails based on the timezone of the location. Some more thinking is needed, though.
See also #122
The text was updated successfully, but these errors were encountered: