Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTC for email sending tasks and fix tests #588

Merged
merged 2 commits into from
Jul 20, 2019

Conversation

bfirsh
Copy link
Member

@bfirsh bfirsh commented Jul 18, 2019

This is the proper fix for #541.

This shouldn't change anything because cron job is run at 1pm UTC, which is always the same day in US timezones. The proper proper fix is #587, but this is a working fix for the tests in the meantime. :)

Ping @jonathan-s @jessykate. If you don't have time to review don't worry – I will merge in a few days to unblock all the other pull requests. There are a few security updates but the build is broken. :(

bfirsh added 2 commits July 18, 2019 11:18
This used to be indeterminite depending on what timezone you
were in, because some tasks were in UTC and some were in local
time.

Email sending should use location timezone, but this will fix
problem for now. See embassynetwork#587
This will stop these tests flaking.
@bfirsh bfirsh force-pushed the consistent-timezone-for-emails branch from 6abe302 to 3fb939c Compare July 18, 2019 10:25
@bfirsh bfirsh mentioned this pull request Jul 18, 2019
@bfirsh bfirsh merged commit b79e324 into embassynetwork:master Jul 20, 2019
@bfirsh bfirsh deleted the consistent-timezone-for-emails branch July 20, 2019 10:14
@bfirsh
Copy link
Member Author

bfirsh commented Jul 20, 2019

forgive me github for I have sinned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant