Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor welcome email logic #122

Closed
jessykate opened this issue Oct 11, 2014 · 1 comment
Closed

Refactor welcome email logic #122

jessykate opened this issue Oct 11, 2014 · 1 comment

Comments

@jessykate
Copy link
Member

This logic is currently in at least 4 places. Also we may have issues with timezones since the code is using datetime.date.today() which we should make timezone aware.

There are some additional paths to the welcome emails not going out since they are often 4 lines in a try block. And if there is an error charging the card then the email won't go out.

This can and should all be refactored so it's MUCH less kludgy.

@bfirsh
Copy link
Member

bfirsh commented Jul 18, 2019

Error charging card has been fixed, IIRC? I think the only remaining issue, besides it being a bit kludgy, is the timezone problem, which I have filed in more detail here: #587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants