Display only valid emojis in recent emoji list #5612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5612 +/- ##
===========================================
+ Coverage 79.76% 79.78% +0.01%
===========================================
Files 2395 2396 +1
Lines 65012 65020 +8
Branches 8262 8263 +1
===========================================
+ Hits 51860 51873 +13
+ Misses 10197 10191 -6
- Partials 2955 2956 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmarty
reviewed
Oct 27, 2025
|
|
||
| val emojis = remember(recentEmojis) { | ||
| (suggestedEmojis + recentEmojis.filter { it !in suggestedEmojis }) | ||
| (suggestedEmojis + recentEmojis).distinct() |
…centEmojis` there - Make sure `GetRecentEmojis` won't return duplicate or invalid emojis. - `ActionListPresenter` now handles merging suggested and recent emojis, not `ActionListView`.
jmartinesp
force-pushed
the
fix/display-only-valid-emojis-in-recents
branch
from
1ff2ff3 to
0fa66f7
Compare
jmartinesp
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
jmartinesp
force-pushed
the
fix/display-only-valid-emojis-in-recents
branch
from
8fcc5b2 to
3587d3e
Compare
ganfra
approved these changes
Oct 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
:libraries:recentemojisand move everything related to pure fetching/modification of recent emojis there.GetRecentEmojisremove duplicates and return only valid emojis (those that are inEmojibase).ActionListPresenterfromActionListView, so we can test it.Motivation and context
I was seeing some duplicate or empty emojis in my list of recent emojis. Some of them were emojis that looked the same visually but had a different representation (i.e. I had 2 green check mark ones, also in EW), but some others were being displayed blank (reactions for TWIM?).
Tests
The unit tests should be enough, but you can try testing them these values by modifying the global account data.
Tested devices
Checklist