Skip to content

Commit 3587d3e

Browse files
jmartinespjmartinesp
committed
Fix tests and previews
1 parent 875008e commit 3587d3e

File tree

2 files changed

+43
-39
lines changed

2 files changed

+43
-39
lines changed

‎features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListStateProvider.kt‎

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ import kotlinx.collections.immutable.persistentListOf
2727
import kotlinx.collections.immutable.toImmutableList
2828

2929
open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
30+
private val suggestedEmojis = persistentListOf("👍️", "👎️", "🔥", "❤️", "👏")
31+
3032
override val values: Sequence<ActionListState>
3133
get() {
3234
val reactionsState = aTimelineItemReactions(1, isHighlighted = true)
@@ -42,7 +44,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
4244
displayEmojiReactions = true,
4345
verifiedUserSendFailure = VerifiedUserSendFailure.None,
4446
actions = aTimelineItemActionList(),
45-
recentEmojis = persistentListOf(),
47+
recentEmojis = suggestedEmojis,
4648
)
4749
),
4850
anActionListState(
@@ -58,7 +60,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
5860
actions = aTimelineItemActionList(
5961
copyAction = TimelineItemAction.CopyCaption,
6062
),
61-
recentEmojis = persistentListOf(),
63+
recentEmojis = suggestedEmojis,
6264
)
6365
),
6466
anActionListState(
@@ -73,7 +75,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
7375
actions = aTimelineItemActionList(
7476
copyAction = TimelineItemAction.CopyCaption,
7577
),
76-
recentEmojis = persistentListOf(),
78+
recentEmojis = suggestedEmojis,
7779
)
7880
),
7981
anActionListState(
@@ -88,7 +90,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
8890
actions = aTimelineItemActionList(
8991
copyAction = null,
9092
),
91-
recentEmojis = persistentListOf(),
93+
recentEmojis = suggestedEmojis,
9294
)
9395
),
9496
anActionListState(
@@ -103,7 +105,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
103105
actions = aTimelineItemActionList(
104106
copyAction = TimelineItemAction.CopyCaption,
105107
),
106-
recentEmojis = persistentListOf(),
108+
recentEmojis = suggestedEmojis,
107109
)
108110
),
109111
anActionListState(
@@ -118,7 +120,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
118120
actions = aTimelineItemActionList(
119121
copyAction = null,
120122
),
121-
recentEmojis = persistentListOf(),
123+
recentEmojis = suggestedEmojis,
122124
)
123125
),
124126
anActionListState(
@@ -131,7 +133,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
131133
displayEmojiReactions = true,
132134
verifiedUserSendFailure = VerifiedUserSendFailure.None,
133135
actions = aTimelineItemActionList(),
134-
recentEmojis = persistentListOf(),
136+
recentEmojis = suggestedEmojis,
135137
)
136138
),
137139
anActionListState(
@@ -144,7 +146,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
144146
displayEmojiReactions = false,
145147
verifiedUserSendFailure = VerifiedUserSendFailure.None,
146148
actions = aTimelineItemActionList(),
147-
recentEmojis = persistentListOf(),
149+
recentEmojis = suggestedEmojis,
148150
),
149151
),
150152
anActionListState(
@@ -157,7 +159,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
157159
displayEmojiReactions = false,
158160
verifiedUserSendFailure = VerifiedUserSendFailure.None,
159161
actions = aTimelineItemPollActionList(),
160-
recentEmojis = persistentListOf(),
162+
recentEmojis = suggestedEmojis,
161163
),
162164
),
163165
anActionListState(
@@ -170,7 +172,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
170172
displayEmojiReactions = true,
171173
verifiedUserSendFailure = VerifiedUserSendFailure.None,
172174
actions = aTimelineItemActionList(),
173-
recentEmojis = persistentListOf(),
175+
recentEmojis = suggestedEmojis,
174176
)
175177
),
176178
anActionListState(
@@ -180,7 +182,7 @@ open class ActionListStateProvider : PreviewParameterProvider<ActionListState> {
180182
displayEmojiReactions = true,
181183
verifiedUserSendFailure = anUnsignedDeviceSendFailure(),
182184
actions = aTimelineItemActionList(),
183-
recentEmojis = persistentListOf(),
185+
recentEmojis = suggestedEmojis,
184186
)
185187
),
186188
)

‎features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenterTest.kt‎

Lines changed: 30 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ class ActionListPresenterTest {
5656
@get:Rule
5757
val warmUpRule = WarmUpRule()
5858

59+
private val suggestedEmojis = persistentListOf("👍️", "👎️", "🔥", "❤️", "👏")
60+
5961
@Test
6062
fun `present - initial state`() = runTest {
6163
val presenter = createActionListPresenter(isDeveloperModeEnabled = true)
@@ -97,7 +99,7 @@ class ActionListPresenterTest {
9799
actions = persistentListOf(
98100
TimelineItemAction.ViewSource,
99101
),
100-
recentEmojis = persistentListOf(),
102+
recentEmojis = suggestedEmojis,
101103
)
102104
)
103105
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -139,7 +141,7 @@ class ActionListPresenterTest {
139141
actions = persistentListOf(
140142
TimelineItemAction.ViewSource,
141143
),
142-
recentEmojis = persistentListOf(),
144+
recentEmojis = suggestedEmojis,
143145
)
144146
)
145147
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -187,7 +189,7 @@ class ActionListPresenterTest {
187189
TimelineItemAction.ViewSource,
188190
TimelineItemAction.ReportContent,
189191
),
190-
recentEmojis = persistentListOf(),
192+
recentEmojis = suggestedEmojis,
191193
)
192194
)
193195
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -234,7 +236,7 @@ class ActionListPresenterTest {
234236
TimelineItemAction.ViewSource,
235237
TimelineItemAction.ReportContent,
236238
),
237-
recentEmojis = persistentListOf(),
239+
recentEmojis = suggestedEmojis,
238240
)
239241
)
240242
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -281,7 +283,7 @@ class ActionListPresenterTest {
281283
TimelineItemAction.ViewSource,
282284
TimelineItemAction.ReportContent,
283285
),
284-
recentEmojis = persistentListOf(),
286+
recentEmojis = suggestedEmojis,
285287
)
286288
)
287289
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -330,7 +332,7 @@ class ActionListPresenterTest {
330332
TimelineItemAction.ReportContent,
331333
TimelineItemAction.Redact,
332334
),
333-
recentEmojis = persistentListOf(),
335+
recentEmojis = suggestedEmojis,
334336
)
335337
)
336338
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -379,7 +381,7 @@ class ActionListPresenterTest {
379381
TimelineItemAction.ReportContent,
380382
TimelineItemAction.Redact,
381383
),
382-
recentEmojis = persistentListOf(),
384+
recentEmojis = suggestedEmojis,
383385
)
384386
)
385387
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -427,7 +429,7 @@ class ActionListPresenterTest {
427429
TimelineItemAction.ViewSource,
428430
TimelineItemAction.Redact,
429431
),
430-
recentEmojis = persistentListOf(),
432+
recentEmojis = suggestedEmojis,
431433
)
432434
)
433435
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -474,7 +476,7 @@ class ActionListPresenterTest {
474476
TimelineItemAction.ViewSource,
475477
TimelineItemAction.Redact,
476478
),
477-
recentEmojis = persistentListOf(),
479+
recentEmojis = suggestedEmojis,
478480
)
479481
)
480482
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -521,7 +523,7 @@ class ActionListPresenterTest {
521523
TimelineItemAction.CopyText,
522524
TimelineItemAction.ViewSource,
523525
),
524-
recentEmojis = persistentListOf(),
526+
recentEmojis = suggestedEmojis,
525527
)
526528
)
527529
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -565,7 +567,7 @@ class ActionListPresenterTest {
565567
TimelineItemAction.CopyText,
566568
TimelineItemAction.ViewSource,
567569
),
568-
recentEmojis = persistentListOf(),
570+
recentEmojis = suggestedEmojis,
569571
)
570572
)
571573
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -613,7 +615,7 @@ class ActionListPresenterTest {
613615
TimelineItemAction.ViewSource,
614616
TimelineItemAction.Redact,
615617
),
616-
recentEmojis = persistentListOf(),
618+
recentEmojis = suggestedEmojis,
617619
)
618620
)
619621
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -665,7 +667,7 @@ class ActionListPresenterTest {
665667
TimelineItemAction.ViewSource,
666668
TimelineItemAction.Redact,
667669
),
668-
recentEmojis = persistentListOf(),
670+
recentEmojis = suggestedEmojis,
669671
)
670672
)
671673
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -715,7 +717,7 @@ class ActionListPresenterTest {
715717
TimelineItemAction.ViewSource,
716718
TimelineItemAction.ReportContent,
717719
),
718-
recentEmojis = persistentListOf(),
720+
recentEmojis = suggestedEmojis,
719721
)
720722
)
721723
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -756,7 +758,7 @@ class ActionListPresenterTest {
756758
actions = persistentListOf(
757759
TimelineItemAction.ViewSource,
758760
),
759-
recentEmojis = persistentListOf(),
761+
recentEmojis = suggestedEmojis,
760762
)
761763
)
762764
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -830,7 +832,7 @@ class ActionListPresenterTest {
830832
TimelineItemAction.CopyText,
831833
TimelineItemAction.Redact,
832834
),
833-
recentEmojis = persistentListOf(),
835+
recentEmojis = suggestedEmojis,
834836
)
835837
)
836838
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -877,7 +879,7 @@ class ActionListPresenterTest {
877879
TimelineItemAction.ViewSource,
878880
TimelineItemAction.Redact,
879881
),
880-
recentEmojis = persistentListOf(),
882+
recentEmojis = suggestedEmojis,
881883
)
882884
)
883885
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -931,7 +933,7 @@ class ActionListPresenterTest {
931933
TimelineItemAction.ViewSource,
932934
TimelineItemAction.Redact,
933935
),
934-
recentEmojis = persistentListOf(),
936+
recentEmojis = suggestedEmojis,
935937
)
936938
)
937939
initialState.eventSink.invoke(ActionListEvents.Clear)
@@ -1025,7 +1027,7 @@ class ActionListPresenterTest {
10251027
TimelineItemAction.CopyText,
10261028
TimelineItemAction.Redact,
10271029
),
1028-
recentEmojis = persistentListOf(),
1030+
recentEmojis = suggestedEmojis,
10291031
)
10301032
)
10311033
}
@@ -1070,7 +1072,7 @@ class ActionListPresenterTest {
10701072
TimelineItemAction.Pin,
10711073
TimelineItemAction.Redact,
10721074
),
1073-
recentEmojis = persistentListOf(),
1075+
recentEmojis = suggestedEmojis,
10741076
)
10751077
)
10761078
}
@@ -1114,7 +1116,7 @@ class ActionListPresenterTest {
11141116
TimelineItemAction.Pin,
11151117
TimelineItemAction.Redact,
11161118
),
1117-
recentEmojis = persistentListOf(),
1119+
recentEmojis = suggestedEmojis,
11181120
)
11191121
)
11201122
}
@@ -1157,7 +1159,7 @@ class ActionListPresenterTest {
11571159
TimelineItemAction.Pin,
11581160
TimelineItemAction.Redact,
11591161
),
1160-
recentEmojis = persistentListOf(),
1162+
recentEmojis = suggestedEmojis,
11611163
)
11621164
)
11631165
}
@@ -1203,7 +1205,7 @@ class ActionListPresenterTest {
12031205
TimelineItemAction.Pin,
12041206
TimelineItemAction.Redact,
12051207
),
1206-
recentEmojis = persistentListOf(),
1208+
recentEmojis = suggestedEmojis,
12071209
)
12081210
)
12091211
}
@@ -1241,7 +1243,7 @@ class ActionListPresenterTest {
12411243
actions = persistentListOf(
12421244
TimelineItemAction.ViewSource
12431245
),
1244-
recentEmojis = persistentListOf(),
1246+
recentEmojis = suggestedEmojis,
12451247
)
12461248
)
12471249
}
@@ -1319,7 +1321,7 @@ class ActionListPresenterTest {
13191321
TimelineItemAction.Pin,
13201322
TimelineItemAction.Redact,
13211323
),
1322-
recentEmojis = persistentListOf(),
1324+
recentEmojis = suggestedEmojis,
13231325
)
13241326
)
13251327
}
@@ -1373,7 +1375,7 @@ class ActionListPresenterTest {
13731375
TimelineItemAction.Pin,
13741376
TimelineItemAction.Redact,
13751377
),
1376-
recentEmojis = persistentListOf(),
1378+
recentEmojis = suggestedEmojis,
13771379
)
13781380
)
13791381
}
@@ -1428,7 +1430,7 @@ class ActionListPresenterTest {
14281430
TimelineItemAction.Pin,
14291431
TimelineItemAction.Redact,
14301432
),
1431-
recentEmojis = persistentListOf(),
1433+
recentEmojis = suggestedEmojis,
14321434
)
14331435
)
14341436
}
@@ -1480,7 +1482,7 @@ class ActionListPresenterTest {
14801482
TimelineItemAction.Reply,
14811483
TimelineItemAction.Redact,
14821484
),
1483-
recentEmojis = persistentListOf(),
1485+
recentEmojis = suggestedEmojis,
14841486
)
14851487
)
14861488
}

0 commit comments

Comments
 (0)