Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(slo): Migrate to test agnostic framework #195927

Merged
merged 21 commits into from
Oct 18, 2024
Merged

chore(slo): Migrate to test agnostic framework #195927

merged 21 commits into from
Oct 18, 2024

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Oct 11, 2024 •
edited by kibanamachine
Loading

Resolves #183397

🌮 Summary

This PR migrates the previously created SLO api tests for stateful and stateless into the agnostic testing framework.

Testing the tests

First, you need to comment the non-SLO tests in these config file:

  • x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.index.ts
  • x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.index.ts

Stateful

# start server
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts

# run tests
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=$

Serverless

# start server
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts

# run tests
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=$

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-management Observability Management User Experience Team v8.16.0 labels Oct 11, 2024
@kdelemme kdelemme marked this pull request as ready for review October 11, 2024 14:00
@kdelemme kdelemme requested a review from a team as a code owner October 11, 2024 14:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kdelemme kdelemme mentioned this pull request Oct 11, 2024
Closed
@maryam-saeidi
Copy link
Member

@kdelemme Did you manage to run these tests on MKI?

dmlemeshko
dmlemeshko reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, I think there are few small things to address:

  • invalidating API key in after hook
  • trying to decrease retry timeout from 5 min to at least 3 (if possible)
  • run this config against Oblt project on MKI to make sure it works for "real" project on QA

x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/create_slo.ts Show resolved Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/create_slo.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/delete_slo.ts Show resolved Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/find_slo.ts Show resolved Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/get_slo.ts Show resolved Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/reset_slo.ts Show resolved Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/slo/update_slo.ts Show resolved Hide resolved
@kdelemme
Copy link
Contributor Author

@dmlemeshko

run this config against Oblt project on MKI to make sure it works for "real" project on QA

How?

@kdelemme
Copy link
Contributor Author

I'm not being able to run this against MKI.
Here's the full slack thread: https://elastic.slack.com/archives/C05UT5PP1EF/p1729175583208439

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

dmlemeshko
dmlemeshko approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM

Thanks a lot for addressing the comments!

@kdelemme
Copy link
Contributor Author

image

@kdelemme kdelemme merged commit 08747f3 into elastic:main Oct 18, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11409878685

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
@kdelemme
chore(slo): Migrate to test agnostic framework (elastic#195927)
071c5fb 
(cherry picked from commit 08747f3)
@kibanamachine kibanamachine mentioned this pull request Oct 18, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
@kdelemme
chore(slo): Migrate to test agnostic framework (elastic#195927)
7e854ec 
(cherry picked from commit 08747f3)
@kibanamachine kibanamachine mentioned this pull request Oct 18, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kdelemme kdelemme mentioned this pull request Oct 18, 2024
Draft
kibanamachine added a commit that referenced this pull request Oct 18, 2024
@kibanamachine @kdelemme
[8.x] chore(slo): Migrate to test agnostic framework (#195927) (#196947)
2e05118 
# Backport

This will backport the following commits from `main` to `8.x`:
- [chore(slo): Migrate to test agnostic framework
(#195927)](#195927)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T19:33:15Z","message":"chore(slo):
Migrate to test agnostic framework
(#195927)","sha":"08747f361aa39ba0e1412d48dc9856ef0806cdf2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-management","v8.16.0"],"title":"chore(slo):
Migrate to test agnostic
framework","number":195927,"url":"https://github.com/elastic/kibana/pull/195927","mergeCommit":{"message":"chore(slo):
Migrate to test agnostic framework
(#195927)","sha":"08747f361aa39ba0e1412d48dc9856ef0806cdf2"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195927","number":195927,"mergeCommit":{"message":"chore(slo):
Migrate to test agnostic framework
(#195927)","sha":"08747f361aa39ba0e1412d48dc9856ef0806cdf2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 18, 2024
@kibanamachine @kdelemme
[8.16] chore(slo): Migrate to test agnostic framework (#195927) (#196946
30b747f 
)

# Backport

This will backport the following commits from `main` to `8.16`:
- [chore(slo): Migrate to test agnostic framework
(#195927)](#195927)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T19:33:15Z","message":"chore(slo):
Migrate to test agnostic framework
(#195927)","sha":"08747f361aa39ba0e1412d48dc9856ef0806cdf2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-management","v8.16.0"],"title":"chore(slo):
Migrate to test agnostic
framework","number":195927,"url":"https://github.com/elastic/kibana/pull/195927","mergeCommit":{"message":"chore(slo):
Migrate to test agnostic framework
(#195927)","sha":"08747f361aa39ba0e1412d48dc9856ef0806cdf2"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195927","number":195927,"mergeCommit":{"message":"chore(slo):
Migrate to test agnostic framework
(#195927)","sha":"08747f361aa39ba0e1412d48dc9856ef0806cdf2"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kevin Delemme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate SLO API tests to deployment agnostic solution
5 participants
@kdelemme @elasticmachine @maryam-saeidi @kibanamachine @dmlemeshko