chore(slo): add api integration tests for main services

[kdelemme]

resolves #187077

🌮 Summary

This PR adds the missing api integration tests on serverless for the update and reset SLO services.

[reakaleek]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[dmlemeshko]

Please don't use supertest service to test API calls, as it will make API calls with operator privileges instead of native realm roles (viewer, editor, etc.)

[dmlemeshko]

I just noticed that SloApiProvider is using supertest service. This service is authenticated with operator user and will use it to run API calls (ignoring roleAuthc.apiKeyHeader). It is not a right approach, please update the service to supertestWithoutAuth. This one has no authentication cached and will use provided API key / Cookie header to make API calls.

[kdelemme]

Thanks, will do

[kdelemme]

resolved in d23a04e

[mgiota]

@kdelemme We are actively working on migrating our current tests to the deployment agnostic framework. slo_api service in serverless folder will soon be removed. The slo_api service has already been migrated to the deployment agnostic folder and @dominiqueclarke is working into migrating the slo tests to the new framework.

[dmlemeshko]

Feel free to ignore, just sharing another way to handle the wait:

If it makes sense to "fail fast" and not slow the test because of high request timeout (30s), the alternative is to set request retry count and decrease timeout. E.g. 10s request timeout and 2s delay before the next attempt

      return await retry.tryWithRetries(
        `Wait for SLO to be created`,
        async () => {
          const response = await supertestWithoutAuth
            .get(`/api/observability/slos/${sloId}`)
            .set(svlCommonApi.getInternalRequestHeader())
            .set(roleAuthc.apiKeyHeader)
            .timeout(10000);
          if (response.body.id === undefined) {
            throw new Error(`No slo with id ${sloId} found`);
          }
          return response.body;
        },
        { retryCount: 5, retryDelay: 2000 }
      );

Alerting API services uses it https://github.com/elastic/kibana/blob/main/x-pack/test/api_integration/deployment_agnostic/services/alerting_api.ts#L97-L130

[dmlemeshko]

x-pack/test_serverless/api_integration/services changes LGTM

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: d23a04e

Metrics [docs]

✅ unchanged

History

• 💔 Build #240039 failed beb8316
• 💔 Build #240030 failed eaaa689

[kdelemme]

Closing as outdated by #195927