Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear scroll after completing scroll requests (backport #14551) #14675

Open
wants to merge 3 commits into
base: 8.16
Choose a base branch
from
Open

fix: clear scroll after completing scroll requests (backport #14551) #14675

wants to merge 3 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2024

Motivation/summary

clear the search context using a clear scroll request for sourcemap and agentcfg search scroll requests

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Related to #14619

This is an automatic backport of pull request #14551 done by [Mergify](https://mergify.com).

@kruskall @mergify
fix: clear scroll after completing scroll requests (#14551)
d95464b 
* fix: clear scroll after completing scroll requests

clear the search context using a clear scroll request
for sourcemap and agentcfg search scroll requests

* lint: fix linter issues

* fix: clear scroll on error too

* test: validate scrollID when clearing

* test: increase sourcemap test coverage to use scroll requests

* feat: log failed clear scroll requests

* Update elasticsearch.go

* Update metadata_fetcher.go

(cherry picked from commit 9487f8d)
@mergify mergify bot requested a review from a team as a code owner November 19, 2024 12:42
@mergify mergify bot mentioned this pull request Nov 19, 2024
Merged
2 tasks
@kruskall
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Nov 19, 2024 •
edited
Loading

queue

🛑 Branch protection settings are not validated anymore

Branch protection is enabled and is preventing Mergify to merge the pull request. Mergify will merge when branch protection settings validate the pull request once again. (detail: Required status check "CLA" is pending.)

@kruskall kruskall enabled auto-merge (squash) November 19, 2024 13:21
@kruskall
Copy link
Member

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Nov 19, 2024

refresh

✅ Pull request refreshed

@v1v
Copy link
Member

v1v commented Nov 19, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Nov 19, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@v1v
Copy link
Member

v1v commented Nov 19, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Nov 19, 2024

refresh

✅ Pull request refreshed

@v1v
Copy link
Member

v1v commented Nov 19, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Nov 19, 2024

refresh

✅ Pull request refreshed

@v1v
Copy link
Member

v1v commented Nov 19, 2024

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Nov 19, 2024

refresh

✅ Pull request refreshed

@v1v
Copy link
Member

v1v commented Nov 19, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Nov 19, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

carsonip
carsonip requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@carsonip carsonip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking to see if we should wait until next release confirmed: only merge after 8.16.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carsonip carsonip carsonip requested changes

@kruskall kruskall kruskall approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kruskall @v1v @carsonip