Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear scroll after completing scroll requests #14551

Merged
merged 10 commits into from
Nov 14, 2024
Merged

fix: clear scroll after completing scroll requests #14551

merged 10 commits into from
Nov 14, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Nov 6, 2024 •
edited by lahsivjar
Loading

Motivation/summary

clear the search context using a clear scroll request for sourcemap and agentcfg search scroll requests

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

Related to #14619

@kruskall
fix: clear scroll after completing scroll requests
1686e78 
clear the search context using a clear scroll request
for sourcemap and agentcfg search scroll requests
@kruskall kruskall requested a review from a team as a code owner November 6, 2024 14:12
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 6, 2024
rubvs
rubvs previously approved these changes Nov 12, 2024
View reviewed changes
1pkg
1pkg previously approved these changes Nov 13, 2024
View reviewed changes
@kruskall kruskall dismissed stale reviews from 1pkg and rubvs via 48cdf3a November 13, 2024 20:43
@kruskall kruskall requested review from 1pkg and rubvs November 13, 2024 20:44
@kruskall kruskall enabled auto-merge (squash) November 14, 2024 09:54
@kruskall kruskall merged commit 9487f8d into elastic:main Nov 14, 2024
11 checks passed
@kruskall kruskall deleted the fix/clear-scroll branch November 14, 2024 10:03
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
@kruskall @mergify
fix: clear scroll after completing scroll requests (#14551)
0313356 
* fix: clear scroll after completing scroll requests

clear the search context using a clear scroll request
for sourcemap and agentcfg search scroll requests

* lint: fix linter issues

* fix: clear scroll on error too

* test: validate scrollID when clearing

* test: increase sourcemap test coverage to use scroll requests

* feat: log failed clear scroll requests

* Update elasticsearch.go

* Update metadata_fetcher.go

(cherry picked from commit 9487f8d)
@mergify mergify bot mentioned this pull request Nov 14, 2024
Merged
2 tasks
mergify bot added a commit that referenced this pull request Nov 14, 2024
@mergify @kruskall
fix: clear scroll after completing scroll requests (#14551) (#14631)
cf08609 
* fix: clear scroll after completing scroll requests

clear the search context using a clear scroll request
for sourcemap and agentcfg search scroll requests

* lint: fix linter issues

* fix: clear scroll on error too

* test: validate scrollID when clearing

* test: increase sourcemap test coverage to use scroll requests

* feat: log failed clear scroll requests

* Update elasticsearch.go

* Update metadata_fetcher.go

(cherry picked from commit 9487f8d)

Co-authored-by: kruskall <[email protected]>
@kruskall
Copy link
Member Author

@Mergifyio backport 8.16

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024 •
edited
Loading

backport 8.16

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 19, 2024
@kruskall @mergify
fix: clear scroll after completing scroll requests (#14551)
d95464b 
* fix: clear scroll after completing scroll requests

clear the search context using a clear scroll request
for sourcemap and agentcfg search scroll requests

* lint: fix linter issues

* fix: clear scroll on error too

* test: validate scrollID when clearing

* test: increase sourcemap test coverage to use scroll requests

* feat: log failed clear scroll requests

* Update elasticsearch.go

* Update metadata_fetcher.go

(cherry picked from commit 9487f8d)
@mergify mergify bot mentioned this pull request Nov 19, 2024
Open
2 tasks
@1pkg 1pkg mentioned this pull request Nov 20, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1pkg 1pkg 1pkg approved these changes

@lahsivjar lahsivjar Awaiting requested review from lahsivjar

@carsonip carsonip Awaiting requested review from carsonip

@rubvs rubvs Awaiting requested review from rubvs

Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kruskall @lahsivjar @carsonip @1pkg @rubvs