Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
[
{
"sheets": [
{
"sheetName": "HCM_ADMIN_CONSOLE_FACILITIES_LIST",
"schemaName": "facility-microplan-ingestion",
"parseEnabled": true
},
{
"sheetName": "HCM_ADMIN_CONSOLE_USERS_LIST",
"schemaName": "user-microplan-ingestion",
"parseEnabled": true,
"processorClass": "UserValidationProcessor"
},
{
"sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY",
"parseEnabled": true,
"processorClass": "BoundaryHierarchyTargetProcessor"
}
Comment on lines 15 to 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Missing schemaName breaks ingestion

parseEnabled sheets must supply schemaName; without it the ingestion service raises a null/empty schema error and aborts processing, so this configuration will fail at runtime. Add the correct schema reference for HCM_CONSOLE_BOUNDARY_HIERARCHY before shipping.

             {
                 "sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY",
+                "schemaName": "<boundary-hierarchy-schema>",
                 "parseEnabled": true,
                 "processorClass": "BoundaryHierarchyTargetProcessor"
             }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
"sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY",
"parseEnabled": true,
"processorClass": "BoundaryHierarchyTargetProcessor"
}
{
"sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY",
"schemaName": "<boundary-hierarchy-schema>",
"parseEnabled": true,
"processorClass": "BoundaryHierarchyTargetProcessor"
}
🤖 Prompt for AI Agents
In health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess around lines 15
to 19 the sheet entry for "HCM_CONSOLE_BOUNDARY_HIERARCHY" enables parsing but
omits the required schemaName, which causes the ingestion service to error and
abort; add the correct "schemaName" property with the appropriate schema
identifier for this sheet (e.g., the target database/schema used for boundary
hierarchy) so the entry includes "sheetName", "parseEnabled": true,
"schemaName": "<CORRECT_SCHEMA_NAME>", and "processorClass":
"BoundaryHierarchyTargetProcessor" before shipping.

],
"processingResultTopic": "hcm-processing-result",
"excelIngestionProcessName": "unified-console-parse"
}
]