-
Notifications
You must be signed in to change notification settings - Fork 46
Create HCM-ADMIN-CONSOLE.excelIngestionProcess #3249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds a new Excel ingestion configuration named "unified-console-parse" defining three sheets to parse, associated schemas/processors, and a processing result topic within health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant U as Uploader
participant EP as Excel Parser
participant P1 as UserValidationProcessor
participant P2 as BoundaryHierarchyTargetProcessor
participant BUS as Processing Result Topic
Note over U,EP: excelIngestionProcessName: "unified-console-parse"
U->>EP: Upload Excel (HCM Admin Console)
rect rgba(221,238,255,0.5)
EP->>EP: Parse sheet "HCM_ADMIN_CONSOLE_FACILITIES_LIST"<br/>schema: facility-microplan-ingestion
end
rect rgba(221,238,255,0.5)
EP->>P1: Parse "HCM_ADMIN_CONSOLE_USERS_LIST"<br/>schema: user-microplan-ingestion
P1-->>EP: Validated user records
end
rect rgba(221,238,255,0.5)
EP->>P2: Parse "HCM_CONSOLE_BOUNDARY_HIERARCHY"
P2-->>EP: Processed hierarchy targets
end
EP->>BUS: Publish results (topic: hcm-processing-result)
Note over BUS: Success/Errors per sheet
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…xcelIngestionProcess.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess(1 hunks)
⏰ Context from checks skipped due to timeout of 10000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript-typescript)
| { | ||
| "sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY", | ||
| "parseEnabled": true, | ||
| "processorClass": "BoundaryHierarchyTargetProcessor" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing schemaName breaks ingestion
parseEnabled sheets must supply schemaName; without it the ingestion service raises a null/empty schema error and aborts processing, so this configuration will fail at runtime. Add the correct schema reference for HCM_CONSOLE_BOUNDARY_HIERARCHY before shipping.
{
"sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY",
+ "schemaName": "<boundary-hierarchy-schema>",
"parseEnabled": true,
"processorClass": "BoundaryHierarchyTargetProcessor"
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY", | |
| "parseEnabled": true, | |
| "processorClass": "BoundaryHierarchyTargetProcessor" | |
| } | |
| { | |
| "sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY", | |
| "schemaName": "<boundary-hierarchy-schema>", | |
| "parseEnabled": true, | |
| "processorClass": "BoundaryHierarchyTargetProcessor" | |
| } |
🤖 Prompt for AI Agents
In health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess around lines 15
to 19 the sheet entry for "HCM_CONSOLE_BOUNDARY_HIERARCHY" enables parsing but
omits the required schemaName, which causes the ingestion service to error and
abort; add the correct "schemaName" property with the appropriate schema
identifier for this sheet (e.g., the target database/schema used for boundary
hierarchy) so the entry includes "sheetName", "parseEnabled": true,
"schemaName": "<CORRECT_SCHEMA_NAME>", and "processorClass":
"BoundaryHierarchyTargetProcessor" before shipping.
Choose the appropriate template for your PR:
Feature/Bugfix Request
JIRA ID
Module
Description
Summary by CodeRabbit