Skip to content

Conversation

@ashish-egov
Copy link
Contributor

@ashish-egov ashish-egov commented Oct 1, 2025

Choose the appropriate template for your PR:

Feature/Bugfix Request

JIRA ID

Module

Description

Summary by CodeRabbit

  • New Features
    • Enable Excel-based data ingestion in the Admin Console with support for Facilities, Users, and Boundary Hierarchy sheets.
    • Add built-in validation for the Users sheet and structured processing for boundary hierarchy data.
    • Centralize processing results to simplify monitoring and follow-up actions.

@ashish-egov ashish-egov requested a review from a team as a code owner October 1, 2025 11:51
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 1, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionGenerate.json is excluded by !**/*.json
  • health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess.json is excluded by !**/*.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Adds a new Excel ingestion configuration named "unified-console-parse" defining three sheets to parse, associated schemas/processors, and a processing result topic within health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess.

Changes

Cohort / File(s) Summary
Excel ingestion config
health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess
New config "unified-console-parse" with sheets: HCM_ADMIN_CONSOLE_FACILITIES_LIST (schema: facility-microplan-ingestion), HCM_ADMIN_CONSOLE_USERS_LIST (schema: user-microplan-ingestion, processorClass: UserValidationProcessor), HCM_CONSOLE_BOUNDARY_HIERARCHY (processorClass: BoundaryHierarchyTargetProcessor); processingResultTopic: hcm-processing-result.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as Uploader
  participant EP as Excel Parser
  participant P1 as UserValidationProcessor
  participant P2 as BoundaryHierarchyTargetProcessor
  participant BUS as Processing Result Topic

  Note over U,EP: excelIngestionProcessName: "unified-console-parse"
  U->>EP: Upload Excel (HCM Admin Console)
  rect rgba(221,238,255,0.5)
    EP->>EP: Parse sheet "HCM_ADMIN_CONSOLE_FACILITIES_LIST"<br/>schema: facility-microplan-ingestion
  end
  rect rgba(221,238,255,0.5)
    EP->>P1: Parse "HCM_ADMIN_CONSOLE_USERS_LIST"<br/>schema: user-microplan-ingestion
    P1-->>EP: Validated user records
  end
  rect rgba(221,238,255,0.5)
    EP->>P2: Parse "HCM_CONSOLE_BOUNDARY_HIERARCHY"
    P2-->>EP: Processed hierarchy targets
  end
  EP->>BUS: Publish results (topic: hcm-processing-result)
  Note over BUS: Success/Errors per sheet
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled through cells in tidy arrays,
Three sheets aligned in spreadsheet ways.
Users checked, boundaries mapped,
Facilities neatly bubble-wrapped.
I thump the topic with results so bright—
“unified-console-parse” takes flight! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description consists solely of the template placeholders without any actual content, leaving required fields like JIRA ID, module name, and a detailed description unfilled. Please complete the pull request description by providing a valid JIRA ID, specifying the impacted module, and adding a detailed description of the new Excel ingestion configuration and its rationale.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely summarizes the primary change of introducing the HCM-ADMIN-CONSOLE.excelIngestionProcess configuration and directly reflects the main addition in the changeset without extraneous details.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b19dc78 and cf6bf5e.

📒 Files selected for processing (1)
  • health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess (1 hunks)
⏰ Context from checks skipped due to timeout of 10000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript-typescript)

Comment on lines 15 to 19
{
"sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY",
"parseEnabled": true,
"processorClass": "BoundaryHierarchyTargetProcessor"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Missing schemaName breaks ingestion

parseEnabled sheets must supply schemaName; without it the ingestion service raises a null/empty schema error and aborts processing, so this configuration will fail at runtime. Add the correct schema reference for HCM_CONSOLE_BOUNDARY_HIERARCHY before shipping.

             {
                 "sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY",
+                "schemaName": "<boundary-hierarchy-schema>",
                 "parseEnabled": true,
                 "processorClass": "BoundaryHierarchyTargetProcessor"
             }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
"sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY",
"parseEnabled": true,
"processorClass": "BoundaryHierarchyTargetProcessor"
}
{
"sheetName": "HCM_CONSOLE_BOUNDARY_HIERARCHY",
"schemaName": "<boundary-hierarchy-schema>",
"parseEnabled": true,
"processorClass": "BoundaryHierarchyTargetProcessor"
}
🤖 Prompt for AI Agents
In health/configs/Data/HCM-ADMIN-CONSOLE.excelIngestionProcess around lines 15
to 19 the sheet entry for "HCM_CONSOLE_BOUNDARY_HIERARCHY" enables parsing but
omits the required schemaName, which causes the ingestion service to error and
abort; add the correct "schemaName" property with the appropriate schema
identifier for this sheet (e.g., the target database/schema used for boundary
hierarchy) so the entry includes "sheetName", "parseEnabled": true,
"schemaName": "<CORRECT_SCHEMA_NAME>", and "processorClass":
"BoundaryHierarchyTargetProcessor" before shipping.

@jagankumar-egov jagankumar-egov merged commit 6a5e57b into console Oct 6, 2025
6 checks passed
@jagankumar-egov jagankumar-egov deleted the ashish-egov-patch-3 branch October 6, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants