fix: pick fixes from main branch #910
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gexfoundry#881) - Use the current service writable config as the baseline for the initial update - Store previousCommonWritable as map to avoid pointer reference syncing with Config Provider Signed-off-by: FelixTing <[email protected]>
edgexfoundry#878) Signed-off-by: FelixTing <[email protected]>
fixes edgexfoundry#872 The send on close channel panic are occasionally observed when a service is terminated. The root cause is that go-mod-bootstrap implements listensForChanges by creating sender channel in the side of receiver, and close the sender channel in the side of receiver will cause the panic. The simplest solution with least code refactor is to not defer close(updateStream) and defer close(errorStream) in listenForPrivateChanges, listenForCommonChanges, and ListenForCustomChanges since there is no need to close the channels. Moreover, edgexfoundry#814 accidentally adds reduandant calls to listen for changes on Writable. As the `cp.loadConfigByProvider` will listen for changes on Writable at https://github.com/edgexfoundry/go-mod-bootstrap/pull/814/files#diff-5346c73553fe1e8350deb1a29ed066b1202c1ea35e57d206adbb6f359ed1d299R332-R343, there is no need to do it again at https://github.com/edgexfoundry/go-mod-bootstrap/pull/814/files#diff-5346c73553fe1e8350deb1a29ed066b1202c1ea35e57d206adbb6f359ed1d299R181-R192. This fix also removes this redundant calls. Signed-off-by: Jude Hung <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## odessa #910 +/- ##
==========================================
- Coverage 46.21% 46.10% -0.12%
==========================================
Files 62 62
Lines 3659 3668 +9
==========================================
Hits 1691 1691
- Misses 1846 1855 +9
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: FelixTing <[email protected]>
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)