fix: pick fixes from main branch #5285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CoreData API doc and fix format Signed-off-by: Bruce Huang <[email protected]>
Signed-off-by: melody <[email protected]>
The sample for POST new device specifies string for both Port and UnitID, which are incorrect and should be corrected to use numbers. Signed-off-by: Jude Hung <[email protected]>
Query events without total count to prevent large dataset query and count. Signed-off-by: Bruce Huang <[email protected]>
Signed-off-by: melody <[email protected]>
Signed-off-by: yichun chou <[email protected]>
Signed-off-by: yichun chou <[email protected]>
Signed-off-by: yichun chou <[email protected]>
FelixTing
force-pushed
the
pick-fix-from-main
branch
from
6776b31 to
b1f1363
Compare
…ndry#5164) CoreCommand GET /device/all API check whether device profile is empty, if empty skip the profile query for the specific device. Close edgexfoundry#5163 Signed-off-by: Bruce Huang <[email protected]>
…oundry#5174) Fix CoreCommand GET /device/all API incorrect totalCount Close edgexfoundry#5172 Signed-off-by: Bruce Huang <[email protected]>
converts a path to the format required for go embed by using '/' as the separator. Close edgexfoundry#5150 Signed-off-by: Cloud Tsai <[email protected]>
…dgexfoundry#5177) CoreData should not return the events when enabling EventPurge and removing device from metadata. This issue occurs when user want to purge large amount of event data. - Adds mark_deleted field to CoreData deviceInfo table - Marks deviceInfo as deletable before deleting events adn readings - Add mark_deleted Close edgexfoundry#5175 Signed-off-by: Bruce Huang <[email protected]>
Signed-off-by: yichun chou <[email protected]>
Signed-off-by: yichun chou <[email protected]>
…undry#5186) Signed-off-by: FelixTing <[email protected]>
…foundry#5189) CoreData apply default retention policy to events not coming from auto events Close edgexfoundry#5188 Signed-off-by: Bruce Huang <[email protected]>
Add the event_id index on reading table to speed up the query. Close edgexfoundry#5176 Signed-off-by: Bruce Huang <[email protected]>
Signed-off-by: yichun chou <[email protected]>
Signed-off-by: FelixTing <[email protected]>
1. go:S117 2. go:S1186 Signed-off-by: Jude Hung <[email protected]>
FelixTing
force-pushed
the
pick-fix-from-main
branch
from
b1f1363 to
efad9a1
Compare
|
Member
Author
Signed-off-by: FelixTing <[email protected]>
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## odessa #5285 +/- ##
==========================================
+ Coverage 26.59% 26.74% +0.15%
==========================================
Files 277 277
Lines 19927 19994 +67
==========================================
+ Hits 5299 5348 +49
- Misses 13373 13387 +14
- Partials 1255 1259 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)