Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UMessage: Add more notification UUri checking #200

Merged

Conversation

billpittman
Copy link
Contributor

@billpittman billpittman commented Jul 2, 2024

Split the uuri::isValidNotification function into two functions, one for the source and one for sink and update appropriate tests/files.

This PR is intended to close issue #188

@billpittman billpittman force-pushed the bug/validator/UMessage branch 2 times, most recently from 1355822 to e56d127 Compare July 2, 2024 19:16
Copy link

github-actions bot commented Jul 2, 2024

Code coverage report is ready! 📈

@billpittman billpittman marked this pull request as ready for review July 2, 2024 21:08
@gregmedd gregmedd linked an issue Jul 3, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 3, 2024

Code coverage report is ready! 📈

Split the uuri::isValidNotification function into two functions, one for
the source and one for sink and update appropriate tests/files.

Signed-off-by: Bill Pittman <[email protected]>
Copy link

github-actions bot commented Jul 3, 2024

Code coverage report is ready! 📈

Copy link
Contributor

@gregmedd gregmedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - my only questions need to be directed at the spec itself.

@gregmedd
Copy link
Contributor

gregmedd commented Jul 8, 2024

Commit history looks good - merging

@gregmedd gregmedd merged commit d38af05 into eclipse-uprotocol:main Jul 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm the UMessage URI checks align with spec
3 participants