Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm the UMessage URI checks align with spec #188

Closed
gregmedd opened this issue Jun 26, 2024 · 1 comment · Fixed by #200
Closed

Confirm the UMessage URI checks align with spec #188

gregmedd opened this issue Jun 26, 2024 · 1 comment · Fixed by #200
Assignees
@billpittman

Comments

@gregmedd
Copy link
Contributor

gregmedd commented Jun 26, 2024 •
edited
Loading

Looking at the UAttributes spec, I think we should be checking both the source and sink against specific rules for each message type. However, we may also need additional UUri validators for this. I think I'll file a separate bug for this so it can be investigated more thoroughly.

Originally posted by @gregmedd in #184 (comment)

The spec indicates that in some message types, there are specific rules for both source and sink URIs. Currently only one of those is checked against specific rules in the UMessage validator code.
@gregmedd gregmedd mentioned this issue Jun 26, 2024
Merged
@billpittman
Copy link
Contributor

I will take a look at this issue.

@billpittman billpittman mentioned this issue Jul 2, 2024
Merged
@gregmedd gregmedd linked a pull request Jul 3, 2024 that will close this issue
UMessage: Add more notification UUri checking #200
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billpittman billpittman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UMessage: Add more notification UUri checking billpittman/up-cpp
2 participants
@billpittman @gregmedd