Bug fixes #184
Merged
Bug fixes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmedd
reviewed
Jun 25, 2024
There was a problem hiding this comment.
It looks like some of the updated builder methods take both a source and sink. One of those has been updated, but the other is still using isValid(). Could those be updated too?
I would also like to see a better commit message since it is unclear what bugs are being fixed and why.
- Switch the uuri validator for every builder to be specific to that message type. - While building response type builder, reqId of the original request was being copied to reqId of response. Fix it to use id field on the original request
ruchirchauhan
force-pushed
the
UMessage-bug-fix
branch
from
98ffb98
to
18626cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs: