Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Keep content assist popup open even if user input has no matches #2261

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] Keep content assist popup open even if user input has no matches #2261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ....eclipse.jface.text/src/org/eclipse/jface/text/contentassist/CompletionProposalPopup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,9 +371,11 @@ public void run() {
}
fFilterOffset= offset;

if (proposals != null && !proposals.isEmpty())
if (proposals != null && !proposals.isEmpty()) {
setProposals(proposals, fIsFilteredSubset);
else {
} else if (fContentAssistant.isShowEmptyList() && !shouldHideOnNoProposals(event, offset)) {
setProposals(Collections.emptyList(), false);
} else {
hide();
if (fContentAssistant.isAutoActivation() && offset > 0 && event != null) {
try {
Expand Down Expand Up @@ -2026,4 +2028,13 @@ public void setSorter(ICompletionProposalSorter sorter) {
void sortProposals(final List<ICompletionProposal> proposals) {
proposals.sort(fSorter::compare);
}

private static boolean shouldHideOnNoProposals(DocumentEvent event, int offset) {
try {
char c= event.getDocument().getChar(offset - 1);
return c == ' ';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better https://docs.oracle.com/javase/8/docs/api/java/lang/Character.html#isWhitespace-char- ?

} catch (BadLocationException e) {
return true;
}
}
}
Loading