[WIP] Keep content assist popup open even if user input has no matches#2261
[WIP] Keep content assist popup open even if user input has no matches#2261trancexpress wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
WIP, DONT MERGE Fixes: eclipse-platform#2260 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
|
There are artifacts with the current change, will have to look into those when I find time: gh2260_content_assist_artifacts.webmOpened eclipse-jdt/eclipse.jdt.ui#1643 for this. |
|
The proposal seems like a clear enhancement to me. I would enjoy the IDE providing this. One thing I believe is important is that if user closes the popup (hits Escape), the popup doesn't show again except if it has actual proposals. |
To be clear, #2260 is for keeping the content assist popup once opened with the usual invocation. We don't aim for #888, i.e. open the content assist popup automatically as soon as there is a proposal. So we don't change how the popup is shown, we only keep it open once shown. Though maybe I misunderstand your concern? Is there some preference that lets content assist show up automatically on typing, that I must test with? |
| private static boolean shouldHideOnNoProposals(DocumentEvent event, int offset) { | ||
| try { | ||
| char c= event.getDocument().getChar(offset - 1); | ||
| return c == ' '; |
There was a problem hiding this comment.
|
Unfortunately no time for this. |
3 participants
WIP, DONT MERGE
Fixes: #2260