Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percent and ratio cleanup in trace points #7511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amicic
Copy link
Contributor

@amicic amicic commented Oct 30, 2024

For resize group of tracepoints in SchedulingDelegate (Balanced GC in OpenJ9), there is a mixup in prints for ratios and factors (values between 0 and 1) and percents (values between 0 and 100).

To avoid confusion '%' is added after the percent value or explicitly stated it's a ratio (or factor), accordingly.

@amicic
Copy link
Contributor Author

amicic commented Oct 30, 2024

@dmitripivkine please, review

For resize group of tracepoints in SchedulingDelegate (Balanced GC in
OpenJ9), there is a mixup in prints for ratios and factors (values
between 0 and 1) and percents (values between 0 and 100).

To avoid confusion '%' is added after the percent value or explicitly
stated it's a ratio (or factor), accordingly.

Signed-off-by: Aleksandar Micic <[email protected]>
Copy link
Contributor

@dmitripivkine dmitripivkine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

Copy link
Contributor

@LinHu2016 LinHu2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@babsingh
Copy link
Contributor

jenkins build all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants