Skip to content

Commit

Permalink
Percent and ratio cleanup in trace points
Browse files Browse the repository at this point in the history 
For resize group of tracepoints in SchedulingDelegate (Balanced GC in
OpenJ9), there is a mixup in prints for ratio and factors (values
between 0 and 1) and percents (values between 0 and 100).

To avoid confusion '%' is added after the percent value or explicitly
stated it's a ratio (or factor), accordingly.

Signed-off-by: Aleksandar Micic <[email protected]>
  • Loading branch information
Aleksandar Micic authored and Aleksandar Micic committed Oct 30, 2024
1 parent 0601b27 commit ab717c7
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions gc/base/j9mm.tdf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -943,23 +943,23 @@ TraceEntry=Trc_MM_AllocationContextBalanced_acquireMPAOLRegionFromNode_Entry Ove
TraceExit=Trc_MM_AllocationContextBalanced_acquireMPAOLRegionFromNode_Exit Overhead=1 Level=1 Group=tarok Template="MM_AllocationContextBalanced::acquireMPAOLRegionFromNode result=%p"
TraceEntry=Trc_MM_MemorySubSpaceTarok_calculateTargetContractSize_Entry2 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_calculateTargetContractSize Entry Allocation size = %zu"
TraceExit=Trc_MM_MemorySubSpaceTarok_calculateExpandSize_Exit2 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_calculateExpandSize Exit1 returning expand size of %zu bytes"
TraceEvent=Trc_MM_MemorySubSpaceTarok_calculateHybridHeapOverhead Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_calculateHybridHeapOverhead GC Componant = %f Memory Componant = %f"
TraceEvent=Trc_MM_MemorySubSpaceTarok_getHeapSizeWithinBounds_1 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_getHeapSizeWithinBounds Better heap size = %zu hybrid overhead %f"
TraceEvent=Trc_MM_MemorySubSpaceTarok_getHeapSizeWithinBounds_2 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_getHeapSizeWithinBounds Changing heap by %f percent"
TraceEvent=Trc_MM_MemorySubSpaceTarok_calculateHybridHeapOverhead Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_calculateHybridHeapOverhead GC Component = %.3f%% Memory Component = %.3f%%"
TraceEvent=Trc_MM_MemorySubSpaceTarok_getHeapSizeWithinBounds_1 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_getHeapSizeWithinBounds Better heap size = %zu hybrid overhead %.3f%%"
TraceEvent=Trc_MM_MemorySubSpaceTarok_getHeapSizeWithinBounds_2 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_getHeapSizeWithinBounds Changing heap by factor of %f"
TraceEvent=Trc_MM_MemorySubSpaceTarok_checkResize_1 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_checkResize ready to resize ? %s"
TraceEvent=Trc_MM_MemorySubSpaceTarok_checkResize_2 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_checkResize heapSizeChange %zd bytes edenChangeRegionsBytes %zd"
TraceEvent=Trc_MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead_1 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead Tenure: %zu bytes, Free Tenure %zu bytes"
TraceEvent=Trc_MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead_2 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead heapSizeChange %zd bytes, free tenure ratio %f"
TraceEvent=Trc_MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead_3 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead free memory mapped to gc overhead: %f"
TraceEvent=Trc_MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead_2 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead heapSizeChange %zd bytes, free tenure ratio %.3f%%"
TraceEvent=Trc_MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead_3 Overhead=1 Level=1 Group=resize Template="MM_MemorySubSpaceTarok_mapMemoryPercentageToGcOverhead free memory mapped to gc overhead: %.3f%%"


TraceEvent=Trc_MM_SchedulingDelegate_calculateGlobalMarkOverhead Overhead=1 Level=1 Group=resize Template="MM_SchedulingDelegate_calculateGlobalMarkOverhead GMP Overhead = %f Increments total time = %zu Concurrent cost = %zu Interval time = %zu"
TraceEvent=Trc_MM_SchedulingDelegate_calculatePartialGarbageCollectOverhead Overhead=1 Level=1 Group=resize Template="MM_SchedulingDelegate_calculatePartialGarbageCollectOverhead PGC Overhead = %f Average PGC interval = %zu Average PGC time = %zu"
TraceEvent=Trc_MM_SchedulingDelegate_calculatePartialGarbageCollectOverhead Overhead=1 Level=1 Group=resize Template="MM_SchedulingDelegate_calculatePartialGarbageCollectOverhead PGC Overhead = %f Average PGC interval %zums Average PGC time %zums"
TraceEvent=Trc_MM_SchedulingDelegate_adjustIdealEdenRegionCount Overhead=1 Level=3 Group=resize Template="SchedulingDelegate_adjustIdealEdenRegionCount Allowed eden region range: %zu - %zu idealEdenRegionCount %zu Eden region change %d"
TraceEvent=Trc_MM_SchedulingDelegate_calculateEdenChangeHeapNotFullyExpanded Overhead=1 Level=3 Group=resize Template="SchedulingDelegate_calculateEdenChangeHeapNotFullyExpanded Hybrid eden overhead %f recent PGC pause time %zu Pause-to-Overhead mapping %f"
TraceEvent=Trc_MM_SchedulingDelegate_calculateRecommendedEdenChangeForExpandedHeap Overhead=1 Level=3 Group=resize Template="SchedulingDelegate_calculateRecommendedEdenChangeForExpandedHeap Hybrid eden overhead %f avg pause time %zu Pause-to-Overhead mapping %f"
TraceEvent=Trc_MM_SchedulingDelegate_calculateEdenChangeHeapNotFullyExpanded Overhead=1 Level=3 Group=resize Template="SchedulingDelegate_calculateEdenChangeHeapNotFullyExpanded Hybrid eden overhead %f recent PGC pause time %zums Pause-to-Overhead mapping %.3f%%"
TraceEvent=Trc_MM_SchedulingDelegate_calculateRecommendedEdenChangeForExpandedHeap Overhead=1 Level=3 Group=resize Template="SchedulingDelegate_calculateRecommendedEdenChangeForExpandedHeap Hybrid eden overhead %f avg pause time %zu Pause-to-Overhead mapping %.3f%%"
TraceEvent=Trc_MM_SchedulingDelegate_calculateRecommendedEdenChangeForExpandedHeap_Exit Overhead=1 Level=1 Group=resize Template="SchedulingDelegate_calculateRecommendedEdenChangeForExpandedHeap_Exit Estimated free tenure = %zu GMP worktime = %zu PGC worktime = %zu PGG avg interval = %zu Eden survival rate %f Recommended eden size = %zu Recommended eden estimated overhead = %f"
TraceEvent=Trc_MM_SchedulingDelegate_checkEdenSizeAfterPgc Overhead=1 Level=3 Group=resize Template="SchedulingDelegate_checkEdenSizeAfterPgc Not fully expanded recomendation %zd Fully expanded recommendation %zd percentage expanded %f"
TraceEvent=Trc_MM_SchedulingDelegate_checkEdenSizeAfterPgc Overhead=1 Level=3 Group=resize Template="SchedulingDelegate_checkEdenSizeAfterPgc Not fully expanded recomendation %zd regions Fully expanded recommendation %zd regions Ratio currently expanded %f"
TraceEvent=Trc_MM_SchedulingDelegate_updatePgcTimePrediction Overhead=1 Level=3 Group=resize Template="SchedulingDelegate_updatePgcTimePrediction x1 %f y1 %f x2 %f y2 %f edenSizeRatio %f _pgcTimeIncreasePerEdenFactor %f"

TraceEvent=Trc_MM_IncrementalGenerationalGC_calculateConcurrentMarkWorkTime Overhead=1 Level=2 Group=resize Template="IncrementalGenerationalGC_calculateConcurrentMarkWorkTime Concurrent GMP ratio %f previous increment concurrent worktime %llu Total concurrent worktime %llu"
Expand Down

0 comments on commit ab717c7

Please sign in to comment.