Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix synchronization of the existing projects #334

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Fix synchronization of the existing projects #334

merged 2 commits into from
Jul 10, 2019

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jul 8, 2019

Signed-off-by: Oleksii Orel [email protected]

What does this PR do?

Add new tests for the project synchronization. Fix implementation.

What issues does this PR fix or reference?

eclipse-che/che#13621

@olexii4 olexii4 requested a review from sunix July 8, 2019 17:46
@olexii4 olexii4 marked this pull request as ready for review July 10, 2019 08:06
@olexii4 olexii4 requested a review from mmorhun July 10, 2019 08:06
@sunix
Copy link
Contributor

sunix commented Jul 10, 2019

@olexii4 I have tested and made few changes:

  • fix one issue with the clonePath that shouldn't be here if it is the name == clonePath
  • remove all the global variable from the test. Problem with these variables is that they make the test not easy to read for a human.

@sunix sunix merged commit 8055dc9 into master Jul 10, 2019
@olexii4 olexii4 deleted the CHE-13621 branch July 10, 2019 14:07
olexii4 added a commit that referenced this pull request Jul 10, 2019
* CHE-13621 fix synchronization of the existing projects

Signed-off-by: Oleksii Orel <[email protected]>

* fix project.clonePath only defined if different from project.name

Signed-off-by: Sun Tan <[email protected]>
olexii4 added a commit that referenced this pull request Jul 11, 2019
* CHE-13621 fix synchronization of the existing projects

Signed-off-by: Oleksii Orel <[email protected]>

* fix project.clonePath only defined if different from project.name

Signed-off-by: Sun Tan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants