Even if the project is deleted from a VS Code workspace, it's back when the Che workspace is re-started

[slemeur]

Description

Deleting a project, refreshing the workspace, the project is back.

Reproduction Steps

OS and version:

Diagnostics:

[sunix]

@olexii4 you fix it i recommand you update these test with devfile: https://github.com/eclipse/che-theia/blob/master/plugins/factory-plugin/tests/projects.spec.ts#L164-L275

[sunix]

@olexii4 I have just reproduced the problem with

metadata:
  name: che7-readme-update-e
projects:
  - name: che
    source:
      location: 'https://github.com/eclipse/che'
      type: git
  - name: web-rails-simple
    source:
      location: 'https://github.com/che-samples/web-rails-simple.git'
      type: git
components:
  - mountSources: true
    command:
      - tail
    args:
      - '-f'
      - /dev/null
    memoryLimit: 512M
    type: dockerimage
    image: sunix/git-devtools
    alias: sunix-git-devtools
apiVersion: 1.0.0

try to check only the devfile tab. and refresh before and after. There is no language server.

[sunix]

For this issue we had 2 root causes:

• Deleting a project would remove it from the devfile as well, but that was broken. Fixed by Fix synchronization of the existing projects che-theia#334 and Fix synchronization of the existing projects (#334) che-theia#340
• Deleting a project can not get rid of some files that are being used by a language server (see screencast from stevan). The language server seems to be still holding the files. @tsmaeder could your team investigate that problem and see if we could do something ?

[olexii4]

@tsmaeder @slemeur
The original issue has two problems. One is a synchronization of the existing projects(fixed in PRs).
The other is a result of a language server work. And we can still reproduce it
https://youtu.be/voqsE7LCVlA

@tsmaeder Is it a normal behavior of LS(language server)? WDYT?

@slemeur Could we close this issue as a fixed one?

[tsmaeder]

@olexii4 yes, when a build is running, for example, class files are produced, this is normal behaviour. There is always a window between the time the delete happens in the ide and when the language server notices the project files are gone.

[tsmaeder]

Btw: I can reproduce the behaviour with VS Code: the /bin folder remains after I delete the project from the file explorer. Repeating the delete gets rid of the project eventually.

[tsmaeder]

Strike that...the project is back again.

[tsmaeder]

Btw: if we move to mounting projects as workspace roots, we can solve this one by first removing the workspace root and then deleting the project.

[slemeur]

@tsmaeder: What do you think it the expected behavior by the end-user?

[sunix]

@tsmaeder If you plan to fix that, could to explain what is your plan ?

This is the responsibility of the language server: files are being deleted and it has to kill the running process.

[l0rd]

Added label in-progress since I believe that what Thomas is working on should fix this issue.

[slemeur]

@tsmaeder : Can you provide an update on this?

[tsmaeder]

Using multi-root workspaces should mitigate this (at least being able to eventually delete the project). However, it is VERY slow going. Wasting time on our self-hosting process.

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.