This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
TemplateRepo Auth pointer #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Buckle <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 19.77% 19.77%
=======================================
Files 81 81
Lines 7061 7061
=======================================
Hits 1396 1396
Misses 5495 5495
Partials 170 170
Continue to review full report at Codecov.
|
hhellyer
approved these changes
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Buckle [email protected]
What type of PR is this ?
What does this PR do ?
Change the type of Authentication in the TemplateRepo object to be a pointer. This enables omitempty to properly hide the field when it is not returned from PFE
Which issue(s) does this PR fix ?
eclipse-archived/codewind#3101
Link to the Codewind repository issue(s) this PR fixes or references:
Does this PR require a documentation change ?
No
Any special notes for your reviewer ?
None