UA driver bug fix: sim mod 2 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing branch at https://github.com/gantech/OpenFAST/tree/f/br_fsi_2 This commit extends the C++ API
This library is needed by openfastcpplib
NOTE: OpenFAST.H and OpenFAST.cpp are not resolved!!!
This commit fixes a bug where HydroDyn would segfault if no outputs were specified in the input file.
Fix segfault in HD when no outputs specified
- vs project didn't like a `UA_OUTS` as both a preprocessor directive and value inside a type - vs project needed LinDyn added to it - moved override of UA_OUTS to UA driver and added initialization in BEMT & FVW so people could override the value before compiling if they wanted to debug UA inside of AeroDyn.
This would have caused issues when merging with the dev-unstable branch of OpenFAST
- update extension of UA output files - explicitly initialize `d_34_to_ac`
Update BlCenBt inputs in MHK r-tests
The ADI_UpdateStates routine makes a copy of the AD_Input, but never destroyed that data after usage. This could lead to memory continously getting allocated during a simulation with either ADI_C_Binding or the AD driver.
ADI: probably memory leak in ADI_UpdateStates
Changes to help compile
…ent_Y AWAE: Mod_AmbWind=3 add error if HR grid not centered on turbine in Y dimension
MD version update
Release 3.5.2
Merge main to dev
switch from -fpic to -fPIC for all gfortran builds
- Edited Body position/orientation used for input mesh setup and initial positions before dynamic relaxation, to hopefully solve that coupled bodies were previously being initialized at 0,0,0. - Coupled bodies should now initialize with position and orientation that is a combination of the relative values in the input file, plus any PtfmInit value passed from the glue code. - With this change, it's possible the p%Standalone flag is not needed - TBD.
…nput ExtLoads: move integers from inputs to parameters
Removes MD driver standalone option, bug fix on initialization
…kwards compatibility
Minor MD bug fixes: Bathymetry
Change input string size for bathgrid and waterkin input files
our regression tests found this issue
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete this sentence
THIS PULL REQUEST IS READY TO MERGE
Feature or improvement description
This PR merges the latest dev branch from the openfast fork and fixes an indexing bug in SimMod 2 (see ba95b23) . When interpolating, the first index of the array was NOT time, so values of alpha, U, and omega were shifted.
Impacted areas of the software
UA driver, SimMod=2.
Additional supporting information
This was discovered by @eamayda in our regression testing.
Test results, if applicable
The GH action tests ran twice. Each individual test passed at least one time, though the two GH actions failed. There seems to be some issue with GH getting python unrelated to my code changes.