Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22337] Fix windows default version and vs-toolset default input #250

Merged
merged 4 commits into from
Nov 27, 2024
Merged

[22337] Fix windows default version and vs-toolset default input #250

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62936b8
Fix windows default version and vs-toolset
rsanchez15 Nov 27, 2024
0c21dd4
Update default windows version and update toolset description
rsanchez15 Nov 27, 2024
395884c
Update missing default windows version
rsanchez15 Nov 27, 2024
ed122e4
Set windows version back to 2019
rsanchez15 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/windows-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ on:
os-version:
description: 'OS version to run the workflow'
required: false
default: 'windows-13'
default: 'windows-2019'
MiguelCompany marked this conversation as resolved.
Show resolved Hide resolved
type: string
vs-toolset:
description: 'Visual Studio toolset to use'
description: 'Visual Studio toolset to use (Default: v141 and v142)'
required: false
default: 'v142'
default: ''
MiguelCompany marked this conversation as resolved.
Show resolved Hide resolved
type: string
colcon-args:
description: 'Extra arguments for colcon cli'
Expand Down