-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22337] Fix windows default version and vs-toolset default input #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Sanchez-Mateos <[email protected]>
rsanchez15
changed the title
Fix windows default version and remove vs-toolset as input
Fix windows default version and vs-toolset default input
Nov 27, 2024
MiguelCompany
requested changes
Nov 27, 2024
Signed-off-by: Raul Sanchez-Mateos <[email protected]>
MiguelCompany
requested changes
Nov 27, 2024
Signed-off-by: Raul Sanchez-Mateos <[email protected]>
rsanchez15
requested review from
MiguelCompany
and removed request for
richiware
November 27, 2024 10:38
MiguelCompany
previously approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
rsanchez15
changed the title
Fix windows default version and vs-toolset default input
[22337] Fix windows default version and vs-toolset default input
Nov 27, 2024
Signed-off-by: Raul Sanchez-Mateos <[email protected]>
MiguelCompany
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Windows CI workflow dispatch to use a valid Windows version by default and removes the vs-toolset default value to use "v141" and "v142".
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist