Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22337] Fix windows default version and vs-toolset default input #250

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Nov 27, 2024

Description

This PR updates the Windows CI workflow dispatch to use a valid Windows version by default and removes the vs-toolset default value to use "v141" and "v142".

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

@rsanchez15 rsanchez15 changed the title Fix windows default version and remove vs-toolset as input Fix windows default version and vs-toolset default input Nov 27, 2024
.github/workflows/windows-ci.yml Outdated Show resolved Hide resolved
.github/workflows/windows-ci.yml Show resolved Hide resolved
.github/workflows/windows-ci.yml Show resolved Hide resolved
.github/workflows/windows-ci.yml Outdated Show resolved Hide resolved
Signed-off-by: Raul Sanchez-Mateos <[email protected]>
@rsanchez15 rsanchez15 requested review from MiguelCompany and removed request for richiware November 27, 2024 10:38
MiguelCompany
MiguelCompany previously approved these changes Nov 27, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added this to the v2.2.6 milestone Nov 27, 2024
@rsanchez15 rsanchez15 changed the title Fix windows default version and vs-toolset default input [22337] Fix windows default version and vs-toolset default input Nov 27, 2024
Signed-off-by: Raul Sanchez-Mateos <[email protected]>
@rsanchez15 rsanchez15 merged commit 691ba7a into master Nov 27, 2024
11 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/windows-ci branch November 27, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants