Skip to content

fix: prevent intra-process tempfile collisions in atomic store writes #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adi-IL wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent intra-process tempfile collisions in atomic store writes #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,15 @@ export async function writeRecord(key, patch) {
await mkdir(BOXES_DIR, { recursive: true })
const prev = (await readRecord(key)) || {}
const next = { ...prev, ...patch, key, updatedAt: new Date().toISOString() }
const tmp = `${recordPath(key)}.tmp.${process.pid}`
await writeFile(tmp, JSON.stringify(next, null, 2))
await rename(tmp, recordPath(key))
const nonce = `${Date.now()}.${Math.random().toString(36).slice(2)}`
const tmp = `${recordPath(key)}.tmp.${process.pid}.${nonce}`
try {
await writeFile(tmp, JSON.stringify(next, null, 2))
await rename(tmp, recordPath(key))
} catch (err) {
try { await unlink(tmp) } catch {}
throw err
}
return next
}

Expand Down